1089837 - Make IPC::Message use MOZ_COUNT_CTOR/DTOR

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Andrew McCreight [:mccr8]]

I'm not sure how we usually deal with adding this kind of thing to the imported Chromium IPC code, but it seems unfortunate that we only detect leaks like bug 1036562 in LSan builds.  In that bug, we're leaking subclasses of IPC::Message, which seems to chain up to Pickle.

Comment 1

[Andrew McCreight [:mccr8]]

Well, we don't even run debug bc1 yet, so that would prevent us from detecting bug 1036562 in debug builds.  I'm not sure if any of the other entrained leaking stuff has leak detection stuff hooked up or not.

Comment 2

[Andrew McCreight [:mccr8]]

Bill suggested that IPC::Message would be a better place for this.

The good news/bad news is that this reveals that we're leaking in a few tests:
  https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=901f33029f4b

It is possible that bug 1089833 will fix some or all of this, as I had that commented out for this run.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Make IPC::Message use MOZ_COUNT_CTOR/DTOR.

I implemented this. There are a few leaks on Try. I'll have to investigate to see if these are real leaks or another bug in my patch.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=91d5c292a94b

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Make IPC::Message use MOZ_COUNT_CTOR/DTOR.

Another simple patch. This one found a leak.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a074577f1a6

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/05868efaa702

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/05868efaa702