Closed Bug 1089837 Opened 9 years ago Closed 8 years ago

Make IPC::Message use MOZ_COUNT_CTOR/DTOR

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

(Whiteboard: [MemShrink:P2])

Attachments

(2 files)

I'm not sure how we usually deal with adding this kind of thing to the imported Chromium IPC code, but it seems unfortunate that we only detect leaks like bug 1036562 in LSan builds.  In that bug, we're leaking subclasses of IPC::Message, which seems to chain up to Pickle.
Assignee: nobody → continuation
Well, we don't even run debug bc1 yet, so that would prevent us from detecting bug 1036562 in debug builds.  I'm not sure if any of the other entrained leaking stuff has leak detection stuff hooked up or not.
Bill suggested that IPC::Message would be a better place for this.

The good news/bad news is that this reveals that we're leaking in a few tests:
  https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=901f33029f4b

It is possible that bug 1089833 will fix some or all of this, as I had that commented out for this run.
Summary: Make Pickle use MOZ_COUNT_CTOR/DTOR → Make IPC::Message use MOZ_COUNT_CTOR/DTOR
Whiteboard: [MemShrink] → [MemShrink:P2]
I implemented this. There are a few leaks on Try. I'll have to investigate to see if these are real leaks or another bug in my patch.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=91d5c292a94b
Depends on: 1217640
Another simple patch. This one found a leak.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a074577f1a6
Attachment #8678486 - Flags: review?(jld)
Attachment #8678486 - Flags: review?(jld) → review+
https://hg.mozilla.org/mozilla-central/rev/05868efaa702
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.