Closed Bug 1089912 Opened 6 years ago Closed 6 years ago

Create dom/security and move CSP and MixedContentBlocker into it

Categories

(Core :: DOM: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: ckerschb, Assigned: ckerschb)

References

(Depends on 2 open bugs)

Details

Attachments

(2 files, 2 obsolete files)

Since Bug 946065 already moved code from content/ into dom/ I think it's time to actually create dom/security and move CSP and also MixedContentBlocker into it. Ideally we would end up having:

> dom/security/csp
> dom/security/mixedcontentblocker

and hopefully soon

> dom/security/sri


Additional note: I already filed Bug 1086619, so that we have not only CSP mochitests in one directory, but also mixed content tests.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
+1
I think it's the better solution to move all the csp-files into
> dom/security

No need for additonal subfolders within security/.

Once we land this patch we should also update:
> https://wiki.mozilla.org/Modules/All#Content_Security
Attachment #8512866 - Flags: review?(sstamm)
Attachment #8512866 - Flags: review?(jst)
Attachment #8512867 - Flags: review?(tanvi)
Attachment #8512867 - Flags: review?(jst)
Comment on attachment 8512866 [details] [diff] [review]
bug_1089912_1_move_csp_into_dom_security.patch

Review of attachment 8512866 [details] [diff] [review]:
-----------------------------------------------------------------

I think this looks good, but defer to jst.
Attachment #8512866 - Flags: review?(sstamm) → review+
Attachment #8512867 - Flags: review?(tanvi) → review+
Attachment #8512866 - Flags: review?(jst) → review+
Attachment #8512867 - Flags: review?(jst) → review+
When pushing to try [1] I realized that I forgot to add dom_security to all the different package-manifest files. incorporated that change now. Carrying over r+ from jst and sstamm.


[1] https://tbpl.mozilla.org/?tree=Try&rev=56915b0016cf
Attachment #8512866 - Attachment is obsolete: true
Attachment #8520221 - Flags: review+
Had to rebase this one as well after pulling mc.
Carrying over r+ from jst and tanvi.
Attachment #8512867 - Attachment is obsolete: true
Attachment #8520224 - Flags: review+
Here we go, try is green:
> https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2008ae73a2f4

Problem fixed by adding dom_security to the different pagacke-manigest files (see Comment 5).

I will land soon, right after landing some csp changes, otherwise I would have to rebase those patches.
Depends on: 1098021
You need to log in before you can comment on or make changes to this bug.