Add test for saving an image from a webpage

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: RobertC, Assigned: RobertC)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 years ago
Add new test to check that a user can save an image from a webpage

STR can be found in the following moztrap test case:
https://moztrap.mozilla.org/manage/case/6889/
Assignee

Comment 1

5 years ago
Attachment #8513451 - Flags: review?(viorela.ioia)
Attachment #8513451 - Flags: review?(jlorenzo)
Attachment #8513451 - Flags: review?(florin.strugariu)
Attachment #8513451 - Flags: review?(florin.strugariu) → review+
Comment on attachment 8513451 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25611

LGTM!
Attachment #8513451 - Flags: review?(jlorenzo) → review+
Uplift to v2.1?
Flags: needinfo?(robert.chira)

Comment 5

5 years ago
I reverted this because the context menu file is in the wrong location:
https://github.com/mozilla-b2g/gaia/commit/8ca1a7b9d43e3f508cc9afa43baea03105dc64d4

Please move it to the system app and re-land the test.
Flags: needinfo?(robert.chira)
Assignee

Comment 6

5 years ago
Attachment #8513451 - Attachment is obsolete: true
Attachment #8515816 - Flags: review?(viorela.ioia)
Attachment #8515816 - Flags: review?(florin.strugariu)
Comment on attachment 8515816 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25755

As Zac asked for a revert on this we also need  a r? from him
Attachment #8515816 - Flags: review?(zcampbell)
Attachment #8515816 - Flags: review?(florin.strugariu) → review+
Assignee

Updated

5 years ago
QA Whiteboard: fxosqa-auto-from-s2
Assignee

Updated

5 years ago
QA Whiteboard: fxosqa-auto-from-s2 → fxosqa-auto-from-s2, fxosqa-auto-s3
Assignee

Updated

5 years ago
QA Whiteboard: fxosqa-auto-from-s2, fxosqa-auto-s3 → [fxosqa-auto-from-s2] [fxosqa-auto-s3]

Comment 8

5 years ago
Comment on attachment 8515816 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25755

r-, see github comments.
Attachment #8515816 - Flags: review?(zcampbell) → review-
Assignee

Comment 9

5 years ago
Comment on attachment 8515816 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25755

I updated the PR.
Attachment #8515816 - Flags: review- → review?(zcampbell)

Comment 10

5 years ago
Comment on attachment 8515816 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25755

r+! Like that we have tidied the activities.py code too.
Attachment #8515816 - Flags: review?(zcampbell) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.