Closed
Bug 1090087
Opened 9 years ago
Closed 9 years ago
Add test for saving an image from a webpage
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: RobertC, Assigned: RobertC)
Details
Attachments
(1 file, 1 obsolete file)
Add new test to check that a user can save an image from a webpage STR can be found in the following moztrap test case: https://moztrap.mozilla.org/manage/case/6889/
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8513451 -
Flags: review?(viorela.ioia)
Attachment #8513451 -
Flags: review?(jlorenzo)
Attachment #8513451 -
Flags: review?(florin.strugariu)
Updated•9 years ago
|
Attachment #8513451 -
Flags: review?(florin.strugariu) → review+
Comment 2•9 years ago
|
||
Comment on attachment 8513451 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25611 LGTM!
Attachment #8513451 -
Flags: review?(jlorenzo) → review+
Comment 3•9 years ago
|
||
Comment on attachment 8513451 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25611 Merged in: https://github.com/mozilla-b2g/gaia/commit/98975a6b7d7c85b304018604cf6df7c65829db6f
Attachment #8513451 -
Flags: review?(viorela.ioia) → review+
Comment 5•9 years ago
|
||
I reverted this because the context menu file is in the wrong location: https://github.com/mozilla-b2g/gaia/commit/8ca1a7b9d43e3f508cc9afa43baea03105dc64d4 Please move it to the system app and re-land the test.
Flags: needinfo?(robert.chira)
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8513451 -
Attachment is obsolete: true
Attachment #8515816 -
Flags: review?(viorela.ioia)
Attachment #8515816 -
Flags: review?(florin.strugariu)
Comment 7•9 years ago
|
||
Comment on attachment 8515816 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25755 As Zac asked for a revert on this we also need a r? from him
Attachment #8515816 -
Flags: review?(zcampbell)
Updated•9 years ago
|
Attachment #8515816 -
Flags: review?(florin.strugariu) → review+
Assignee | ||
Updated•9 years ago
|
QA Whiteboard: fxosqa-auto-from-s2
Assignee | ||
Updated•9 years ago
|
QA Whiteboard: fxosqa-auto-from-s2 → fxosqa-auto-from-s2, fxosqa-auto-s3
Assignee | ||
Updated•9 years ago
|
QA Whiteboard: fxosqa-auto-from-s2, fxosqa-auto-s3 → [fxosqa-auto-from-s2] [fxosqa-auto-s3]
Comment 8•9 years ago
|
||
Comment on attachment 8515816 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25755 r-, see github comments.
Attachment #8515816 -
Flags: review?(zcampbell) → review-
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8515816 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25755 I updated the PR.
Attachment #8515816 -
Flags: review- → review?(zcampbell)
Comment 10•9 years ago
|
||
Comment on attachment 8515816 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25755 r+! Like that we have tidied the activities.py code too.
Attachment #8515816 -
Flags: review?(zcampbell) → review+
Comment 11•9 years ago
|
||
Comment on attachment 8515816 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25755 https://github.com/mozilla-b2g/gaia/commit/0194440e8b3d7827bca78371367c75529b4c0e8b
Attachment #8515816 -
Flags: review?(viorela.ioia)
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•