1090103 - [Loop] FxOS Loop client needs to send channel in call setup messages

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

This is the FxOS Loop client counterpart to bug 1033579.

Comment 1

[Maria Angeles Oteo (:oteo)]

According to https://wiki.mozilla.org/Loop/Architecture/MVP#POST_.2Fcalls

channel=mobile, will be used for the Firefox OS Mobile client.

That's we need to implement in this bug (see also https://bugzilla.mozilla.org/show_bug.cgi?id=1034538#c6 to check what we agreed)

We need Loop server team coordination so they are aware of this change and provide the corresponding API key that should be used.

Comment 2

[Rémy Hubscher (:natim)]

This is already handled on the server side. The mobile channel will use the default channel which is the release api key.

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Rémy Hubscher (:natim) from comment #2)
> This is already handled on the server side. The mobile channel will use the
> default channel which is the release api key.

Well, good to know. I'll add the bits we need for sending the channel name ('mobile') as we don't send it yet. Thanks!

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/259

Comment 5

[Maria Angeles Oteo (:oteo)]

Please, uplift the patch to 1.1 branch after landing in master

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8512969 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/259

LGTM José, thanks a lot

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Landed on master branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/04dd322b92ced6729c1d8ca729b7a0c05c4bbf68

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Landed on 1.1 branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/797e0d2b16bfcfa967a20dd6674748f9a2c6eaa8