Status
People
(Reporter: glandium, Assigned: glandium)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
10.20 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
| Comment hidden (empty) |
|
(Assignee) | |
Comment 1•4 years ago
|
||
Created attachment 8512504 [details] [diff] [review] Define stlport dependencies in moz.build
Attachment #8512504 -
Flags: review?(mshal)
|
||
Comment 2•4 years ago
|
||
Comment on attachment 8512504 [details] [diff] [review] Define stlport dependencies in moz.build Do we still need to set STLPORT_LIBS in js/src/configure.in? And do we need to AC_SUBST / export STLPORT_LIBS in configure.in? It is already AC_SUBST'd in android.m4, which appears to be the only place it's set in autoconf.
Attachment #8512504 -
Flags: review?(mshal) → review+
|
|
(Assignee) | |
Comment 3•4 years ago
|
||
(In reply to Michael Shal [:mshal] from comment #2) > Comment on attachment 8512504 [details] [diff] [review] > Define stlport dependencies in moz.build > > Do we still need to set STLPORT_LIBS in js/src/configure.in? Yes, the value is still needed for non-stlport builds (--enable-libstdc++ or something) > And do we need to AC_SUBST / export STLPORT_LIBS in configure.in? Yes, for the same reason. > It is already AC_SUBST'd in android.m4, which appears to be the only > place it's set in autoconf. Indeed, the AC_SUBST in configure.in could go away.
|
|
(Assignee) | |
Comment 4•4 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/afdcad4e027e
|
||
Comment 5•4 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/afdcad4e027e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
|
||
Updated•9 months ago
|
||
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.