Closed Bug 1090107 Opened 6 years ago Closed 6 years ago

Define stlport dependencies in moz.build

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla36

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

Define stlport dependencies in moz.build
10.20 KB, patch
mshal
: review+
Details | Diff | Splinter Review 
No description provided.
Comment on attachment 8512504 [details] [diff] [review]
Define stlport dependencies in moz.build

Do we still need to set STLPORT_LIBS in js/src/configure.in?

And do we need to AC_SUBST / export STLPORT_LIBS in configure.in? It is already AC_SUBST'd in android.m4, which appears to be the only place it's set in autoconf.
Attachment #8512504 - Flags: review?(mshal) → review+
(In reply to Michael Shal [:mshal] from comment #2)
> Comment on attachment 8512504 [details] [diff] [review]
> Define stlport dependencies in moz.build
> 
> Do we still need to set STLPORT_LIBS in js/src/configure.in?

Yes, the value is still needed for non-stlport builds (--enable-libstdc++ or something)

> And do we need to AC_SUBST / export STLPORT_LIBS in configure.in?

Yes, for the same reason.

> It is already AC_SUBST'd in android.m4, which appears to be the only
> place it's set in autoconf.

Indeed, the AC_SUBST in configure.in could go away.
https://hg.mozilla.org/mozilla-central/rev/afdcad4e027e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.