1090107 - Define stlport dependencies in moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Define stlport dependencies in moz.build

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8512504 [details] [diff] [review]
Define stlport dependencies in moz.build

Do we still need to set STLPORT_LIBS in js/src/configure.in?

And do we need to AC_SUBST / export STLPORT_LIBS in configure.in? It is already AC_SUBST'd in android.m4, which appears to be the only place it's set in autoconf.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Michael Shal [:mshal] from comment #2)
> Comment on attachment 8512504 [details] [diff] [review]
> Define stlport dependencies in moz.build
> 
> Do we still need to set STLPORT_LIBS in js/src/configure.in?

Yes, the value is still needed for non-stlport builds (--enable-libstdc++ or something)

> And do we need to AC_SUBST / export STLPORT_LIBS in configure.in?

Yes, for the same reason.

> It is already AC_SUBST'd in android.m4, which appears to be the only
> place it's set in autoconf.

Indeed, the AC_SUBST in configure.in could go away.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/afdcad4e027e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/afdcad4e027e