1090170 - WebSocketChannel is kept alive until shutdown

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: crash.patch

Comment 1

[Daniel Stenberg [:bagder]]

Comment on attachment 8512620 [details] [diff] [review]
crash.patch

Review of attachment 8512620 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, apart from this little nit on a comment!

Do you have a successful try-run as well?

::: netwerk/protocol/websocket/WebSocketChannel.cpp
@@ +1974,5 @@
> +  {}
> +
> +  NS_IMETHOD Run()
> +  {
> +    // Register for prefs change notifications

This comment seems out of place, as this isn't registering for notifications, it actually removes the observer!

Comment 2

[Andrea Marchesini [:baku]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=4fb14a1fe22c

pushed to try and comments applied. Waiting for a green result.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Do we need this on branches too?

Comment 4

[Daniel Stenberg [:bagder]]

Probably, this bug was introduced in my websocket patch for bug 939318.

Comment 5

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/251ac1f7b614

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Please ask then approval for v35 for the patch.

Comment 7

[Andrea Marchesini [:baku]]

Comment on attachment 8512620 [details] [diff] [review]
crash.patch

Approval Request Comment
[Feature/regressing bug #]: bug 939318
[User impact if declined]: a leak
[Describe test coverage new/current, TBPL]: none because the leak disappear on shutdown.
[Risks and why]: none 
[String/UUID change made/needed]: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/251ac1f7b614

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/569c89370744