WebSocketChannel is kept alive until shutdown

RESOLVED FIXED in Firefox 35

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

Trunk
mozilla36
Points:
---

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8512620 [details] [diff] [review]
crash.patch
Attachment #8512620 - Flags: review?(daniel)
Comment on attachment 8512620 [details] [diff] [review]
crash.patch

Review of attachment 8512620 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, apart from this little nit on a comment!

Do you have a successful try-run as well?

::: netwerk/protocol/websocket/WebSocketChannel.cpp
@@ +1974,5 @@
> +  {}
> +
> +  NS_IMETHOD Run()
> +  {
> +    // Register for prefs change notifications

This comment seems out of place, as this isn't registering for notifications, it actually removes the observer!
Attachment #8512620 - Flags: review?(daniel) → review+
(Assignee)

Comment 2

4 years ago
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=4fb14a1fe22c

pushed to try and comments applied. Waiting for a green result.

Comment 3

4 years ago
Do we need this on branches too?
Probably, this bug was introduced in my websocket patch for bug 939318.
Blocks: 1079385

Comment 6

4 years ago
Please ask then approval for v35 for the patch.
(Assignee)

Comment 7

4 years ago
Comment on attachment 8512620 [details] [diff] [review]
crash.patch

Approval Request Comment
[Feature/regressing bug #]: bug 939318
[User impact if declined]: a leak
[Describe test coverage new/current, TBPL]: none because the leak disappear on shutdown.
[Risks and why]: none 
[String/UUID change made/needed]: none
Attachment #8512620 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/251ac1f7b614
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Depends on: 1090198
No longer depends on: 1090198
Attachment #8512620 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/569c89370744
status-firefox35: --- → fixed
status-firefox36: --- → fixed
You need to log in before you can comment on or make changes to this bug.