1090205 - Move getReversedHost from Bookmarks.jsm to PlacesUtils

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Comment 1

[Althaf Hameez [:ahameez]]

try run: 
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ba9bc79be1f4

Comment 2

[Althaf Hameez [:ahameez]]

Attachment: bug1090205_move_getReversedHost.diff

Comment 3

[Althaf Hameez [:ahameez]]

Cancelled the last try because I put in the wrong try syntax. Here is the updated try run.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=77bedb1dda9a

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8512678 [details] [diff] [review]
bug1090205_move_getReversedHost.diff

Review of attachment 8512678 [details] [diff] [review]:
-----------------------------------------------------------------

thanks! please set checkin-needed when ready.

::: toolkit/components/places/PlacesUtils.jsm
@@ +392,5 @@
> +   * @param url
> +   *        the URL to generate a rev host for.
> +   * @return the reversed host string.
> +   */
> +  getReversedHost: function(url) {

nit: you can use a shorthand here (part of ES6)

getReversedHost(url) {
  return url.host.split("").reverse().join("") + ".";
},

or you could even do

getReversedHost(url)
  url.host.split("").reverse().join("") + ".",

Comment 5

[Althaf Hameez [:ahameez]]

Attachment: bug1090205_move_getReversedHost.diff v2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef341d4cca38

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ef341d4cca38