Closed
Bug 1090313
Opened 10 years ago
Closed 10 years ago
"Request Desktop Site" from about:home shouldn't prompt to report site issue
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 36
People
(Reporter: miketaylr, Assigned: miketaylr)
Details
Attachments
(1 file)
|
2.28 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
From about:home (or any other non-webfacing URL), select "Request Desktop Site". Nightly users will get a toast "Report Site Issue?", which doesn't make any sense. See Bug 1089838 which tracks whether Request Desktop Site should be disabled or not. But we should fix this independently of whatever happens there, IMO.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → miket
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8512820 [details] [diff] [review] 1090313.patch Review of attachment 8512820 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #8512820 -
Flags: review?(margaret.leibovic) → review+
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/37afcde2fd22
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/37afcde2fd22
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
|
||
Comment 6•10 years ago
|
||
"Request Desktop Site" from about:home doesn't prompt the "report site issue" notification, so: Verified fixed on: device: LG Nexus 4 (Android 4.4) build: Firefox for Android 36.0a1 (2014-10-31)
Status: RESOLVED → VERIFIED
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•