Closed Bug 1090313 Opened 5 years ago Closed 5 years ago

"Request Desktop Site" from about:home shouldn't prompt to report site issue

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 36

People

(Reporter: miketaylr, Assigned: miketaylr)

Details

Attachments

(1 file)

From about:home (or any other non-webfacing URL), select "Request Desktop Site". Nightly users will get a toast "Report Site Issue?", which doesn't make any sense.


See Bug 1089838 which tracks whether Request Desktop Site should be disabled or not. But we should fix this independently of whatever happens there, IMO.
Assignee: nobody → miket
Attached patch 1090313.patchSplinter Review
Comment on attachment 8512820 [details] [diff] [review]
1090313.patch

Review of attachment 8512820 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8512820 - Flags: review?(margaret.leibovic) → review+
Thanks!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/37afcde2fd22
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
"Request Desktop Site" from about:home doesn't prompt the "report site issue" notification, so:
Verified fixed on:
device: LG Nexus 4 (Android 4.4)
build: Firefox for Android 36.0a1 (2014-10-31)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.