Closed
Bug 1090315
Opened 10 years ago
Closed 9 years ago
Intermittent browser_double_close_tab.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/general/head.js:630 - Error: Timed out while waiting for a 'load'' event
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: cbook, Assigned: mrbkap)
References
()
Details
(Keywords: intermittent-failure)
Attachments
(1 file, 2 obsolete files)
2.33 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
Windows XP 32-bit mozilla-central pgo test mochitest-browser-chrome-1
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=541798&repo=mozilla-central
14:58:09 INFO - 418 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_double_close_tab.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/general/head.js:630 - Error: Timed out while waiting for a 'load'' event
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 2•10 years ago
|
||
Inactive; closing (see bug 1180138).
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
Updated•9 years ago
|
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 5•9 years ago
|
||
The head.js file here uses CPOWs to wait for loaded events on arbitrary tabs, we can do better.
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9ae5cf0087b
Attachment #8740531 -
Flags: review?(felipc)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mrbkap
Assignee | ||
Comment 6•9 years ago
|
||
The first hunk wasn't necessary (about:newtab loads in the parent
anyway).
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a0fe9baebf1
Attachment #8740661 -
Flags: review?(felipc)
Assignee | ||
Updated•9 years ago
|
Attachment #8740531 -
Attachment is obsolete: true
Attachment #8740531 -
Flags: review?(felipc)
Assignee | ||
Comment 7•9 years ago
|
||
Sorry about the bugspam. I guess the last patch raced with the browser actually loading. BrowserTestUtils.browserLoaded actually already gives us everything we need.
Attachment #8740726 -
Flags: review?(felipc)
Assignee | ||
Updated•9 years ago
|
Attachment #8740661 -
Attachment is obsolete: true
Attachment #8740661 -
Flags: review?(felipc)
Comment 8•9 years ago
|
||
Comment on attachment 8740726 [details] [diff] [review]
Even better patch
Review of attachment 8740726 [details] [diff] [review]:
-----------------------------------------------------------------
I was gonna say "if promiseTabLoadEvent needs to handle more things that what BrowserTestUtils does, then perhaps BrowserTestUtils should be doing it itself". Until I saw that now it basically is just a `BTU.loadURI; yield BTU.browserLoaded`. nice!
Attachment #8740726 -
Flags: review?(felipc) → review+
Comment 10•9 years ago
|
||
Reporter | ||
Comment 11•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/19617346330c
https://hg.mozilla.org/mozilla-central/rev/3e17cc4625da
Status: REOPENED → RESOLVED
Closed: 10 years ago → 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•