Closed Bug 1090315 Opened 5 years ago Closed 4 years ago

Intermittent browser_double_close_tab.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/general/head.js:630 - Error: Timed out while waiting for a 'load'' event

Categories

(Core :: General, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: cbook, Assigned: mrbkap)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 2 obsolete files)

Windows XP 32-bit mozilla-central pgo test mochitest-browser-chrome-1

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=541798&repo=mozilla-central

14:58:09 INFO - 418 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_double_close_tab.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/general/head.js:630 - Error: Timed out while waiting for a 'load'' event
Inactive; closing (see bug 1180138).
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Attached patch Remove CPOW usage (obsolete) — Splinter Review
The head.js file here uses CPOWs to wait for loaded events on arbitrary tabs, we can do better.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9ae5cf0087b
Attachment #8740531 - Flags: review?(felipc)
Assignee: nobody → mrbkap
Attached patch Better patch (obsolete) — Splinter Review
The first hunk wasn't necessary (about:newtab loads in the parent
anyway).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a0fe9baebf1
Attachment #8740661 - Flags: review?(felipc)
Attachment #8740531 - Attachment is obsolete: true
Attachment #8740531 - Flags: review?(felipc)
Sorry about the bugspam. I guess the last patch raced with the browser actually loading. BrowserTestUtils.browserLoaded actually already gives us everything we need.
Attachment #8740726 - Flags: review?(felipc)
Attachment #8740661 - Attachment is obsolete: true
Attachment #8740661 - Flags: review?(felipc)
Comment on attachment 8740726 [details] [diff] [review]
Even better patch

Review of attachment 8740726 [details] [diff] [review]:
-----------------------------------------------------------------

I was gonna say "if promiseTabLoadEvent needs to handle more things that what BrowserTestUtils does, then perhaps BrowserTestUtils should be doing it itself".  Until I saw that now it basically is just a `BTU.loadURI; yield BTU.browserLoaded`. nice!
Attachment #8740726 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/19617346330c
https://hg.mozilla.org/mozilla-central/rev/3e17cc4625da
Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Duplicate of this bug: 1263306
You need to log in before you can comment on or make changes to this bug.