Closed
Bug 1090317
Opened 10 years ago
Closed 10 years ago
Optimize job eta computation
Categories
(Tree Management :: Treeherder, defect, P1)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: mdoglio)
References
(Blocks 1 open bug)
Details
(Keywords: perf, regression)
Attachments
(1 file)
In the last meeting it was suggested that we add a small delay to the tooltips shown when hovering the job symbols in the main UI, so that mouse movement didn't trigger hundreds of expensive calculations (eg for ETA) that end up being unused.
|
||
Updated•10 years ago
|
Assignee: nobody → mdoglio
|
Reporter | |
Updated•10 years ago
|
Keywords: regression
|
Assignee | |
Comment 1•10 years ago
|
||
I opened a PR to completely remove the onhover event callback and move the calculation and visualization to the bottom panel
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8523085 -
Flags: review?(emorley)
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•10 years ago
|
Summary: Add small delay to job tooltips to prevent mouse movement from triggering unintentionally → Optimize job eta computation
|
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8523085 [details] [review] Github PR #271 on treeherder-ui r+ but I'd also be interested to see how much of a perf increase we'd get from removing the duration for completed jobs (it's only a time subtraction/formatting, but over a few thousand jobs...?).
Attachment #8523085 -
Flags: review?(emorley) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
I don't know honestly, I would take care of it in a separate PR. The reason for this one was to avoid running code on hover. If we do it for completed jobs it would be more about jobs load time
|
||
Comment 5•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/6e5629ea96af6581156c590d5f70cd1c4e5a7975 Bug 1090317 - Optimize job eta computation
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 6•10 years ago
|
||
>+ <span ng-if="eta > 0">{{eta}} mins overdue, tipically takes ~ {{tipical_eta}} mins</span>
>+ <span ng-if="eta == 0">ETA any minute now, typically takes ~ {{tipical_eta}} mins</span>
those should be "typically" and "typical_eta".|
|
Reporter | |
Comment 7•10 years ago
|
||
Missed review comment: https://github.com/mozilla/treeherder-ui/pull/271#discussion_r20440712
Flags: needinfo?(mdoglio)
|
|
Assignee | |
Comment 8•10 years ago
|
||
I'm gonna push a fixup directly to master
Flags: needinfo?(mdoglio)
|
|
||
Comment 9•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/68085be1bb1406148e85dd7a24add3cf21ef44a6 fixup! Bug 1090317 - Optimize job eta computation
|
|
||
Comment 10•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/1200de7b442b52d8ce4b2b250a636104b8a195b2 Bug 1090317 - Optimize job eta computation https://github.com/mozilla/treeherder/commit/2eeb908dfbd0623d05a60cc119677e1eef216803 fixup! Bug 1090317 - Optimize job eta computation
You need to log in
before you can comment on or make changes to this bug.
Description
•