1090355 - add cert_override.txt to the talos main thread i/o whitelist so bug 1085509 (certificate override telemetry) can land

Status: RESOLVED WORKSFORME

(Testing :: Talos, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

From http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32/1414495489/mozilla-inbound_win7-ix_test-xperf-bm110-tests1-windows-build2431.txt.gz, xperf seems to be failing with the following:

06:01:11     INFO -  TEST-UNEXPECTED-FAIL | mainthreadio | File '{profile}\cert_override.txt' was accessed and we were not expecting it: {'Count': 1, 'Duration': 0.033408, 'RunCount': 1}

with the patch from bug 1085509 (adding some certificate override telemetry). Unfortunately, it is the case that the implementation reads this file on the main thread. This has been a long-standing issue that does need to be fixed, but at the moment this telemetry is more important. As far as I can tell, all we need to do is add '{profile}\\cert_override.txt' to talos/mtio-whitelist.json.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

ok, so this is 100% expected?

oddly enough I had emailed aklotz yesterday about this (and a couple other small changes).

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: patch

Joel, looks like you've worked on this file in the past. Is this all that's needed? Thanks.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

(In reply to Joel Maher (:jmaher) from comment #1)
> ok, so this is 100% expected?
> 
> oddly enough I had emailed aklotz yesterday about this (and a couple other
> small changes).

Whoops - didn't see your comment before I posted the patch. Yes, this is actually expected now, although it is unfortunate (it didn't happen before because presumably none of the talos tests visited sites that caused the override service to be instantiated (i.e. they all had certificates that validated successfully)).

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: fix cert_override, profile taking too long, and profile path issues (1.0)

sorry for taking this over, but there are 2 other issues to fix, I would rather fix them in the same bug and get things landed and solved right away!

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8512783 [details] [diff] [review]
fix cert_override, profile taking too long, and profile path issues (1.0)

Review of attachment 8512783 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me, but then again this isn't my area of expertise.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

I am double checking with :vladan before doing this.  At most we will just upload the original patch in this bug instead of fixing the 3 problems.

Comment 7

[Dana Keeler (she/her) (use needinfo) [:keeler]]

So, it looks like we won't have to add cert_override.txt to the whitelist after all. I'll leave this open if you want to use this bug to track the other issues for now. (Although, feel free to resolve this as WORKSFORME or something.)

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

we will handle the other bugs in their own place.  Thanks for fixing the telemetry and cert stuff!