109039 - Mayscript attribute needed on <OBJECT> tag; this is not HTML4 compliant

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Magnus.Kessler]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.5+)
Gecko/20011107
BuildID:    20011110703

For LiveConnect to work correctly, one needs to set the mayscript attribute on
the object tag. Just setting it as a parameter is not sufficient. The mayscript
attribute of the object tag is not part of the HTML4 specs.



Reproducible: Always

Example (taken from http://www.hubick.com/software/Misc/LiveConnect/test3.htm):

<object name="TestApplet" id="TestApplet"
classid="clsid:8AD9C840-044E-11D1-B3E9-00805F499D93" width="300" height="100"
codebase="j2re1_3_0-win.exe#Version=1,3,0,0" mayscript="true" scriptable="true">
  <param name="type" value="application/x-java-applet;version=1.3"/>
  <param name="mayscript" value="true"/>
  <param name="scriptable" value="true"/>
  <param name="code" value="Test3Applet"/>
</object><br/>

Notice the mayscript attribute on the object tag above. The code above works fine.

Leaving out the attribute (see below) on the object tag causes an Exception in
the applet. However, this version is validated correct HTML 4.01

<object name="TestApplet" id="TestApplet"
classid="clsid:8AD9C840-044E-11D1-B3E9-00805F499D93" width="300" height="100"
codebase="j2re1_3_0-win.exe#Version=1,3,0,0">
  <param name="type" value="application/x-java-applet;version=1.3"/>
  <param name="mayscript" value="true"/>
  <param name="scriptable" value="true"/>
  <param name="code" value="Test3Applet"/>
</object><br/>

Comment 1

[Boris Zbarsky [:bzbarsky]]

over to liveconnect

Comment 2

[Phil Schwartau]

--> OJI

I'm not expert in these matters, but cc'ing [e-mail] 
because of his comment about |mayscript| in bug 60018.

Also see bug 75588: 
Exception thrown (for mayscript) when JSObject.getWindow() called in JAVA applet  

This was marked invalid, but in fact is really a duplicate of bug 80802:
LiveConnect for HTML4 OBJECT tag currently not supported
(which has just recently been fixed)

Was support for |mayscript| omitted in this fix? 

Comment 3

[Peter Lubczynski]

This is a plugin bug...over to me.

MAYSCRIPT isn't the one attribute we need to fix. There are a few getters,
besides GetMayScript(), in nsPluginInstanceOwner that are incorrect.

Comment 4

[Peter Lubczynski]

Attachment: working patch

Comment 5

[av (gone)]

There is a typo in the patch: you use "NAME" in GetCode(). Otherwise looks good.

Comment 6

[Peter Lubczynski]

Attachment: clean-up patch

Made that change and also fixed the PRLOG problem with fNPP. Please review.

Comment 7

[av (gone)]

Comment on attachment 57767 [details] [diff] [review]
clean-up patch

r=av

Comment 8

[Patrick C. Beard]

Comment on attachment 57767 [details] [diff] [review]
clean-up patch

sr=beard

Comment 9

[Peter Lubczynski]

Patch checked into the trunk, marking FIXED.

Comment 10

[Patty Mac]

Verified the patch.

Comment 11

[Peter Lubczynski]

Nominating for the 0.9.4 branch as this fixes "mayscript" when using Java
through the object tag and fixes the failing testcase in bug 80802.

Comment 12

[Peter Lubczynski]

*** Bug 121529 has been marked as a duplicate of this bug. ***

Comment 13

[Phil Schwartau]

When this bug is verified, also check this testcase from bug 121529:

  http://www.ccs.neu.edu/home/bcortez/mozilla_tests/80802/bug_test.html

Comment 14

[Michael Dunn]

nominated by Peter L

Comment 15

[Patty Mac]

Since this's been nominated for edt0.9.4, I'm reopening this bug. This bug is
already fixed in the commercial trunk build.

Comment 16

[Peter Lubczynski]

um...if a bug is fixed in the trunk, then it should be marked FIXED, no?

Comment 17

[Patrick C. Beard]

Comment on attachment 57767 [details] [diff] [review]
clean-up patch

This should be pushed to the 0.9.4 branch because it does the proper mapping of
various <EMBED> attributes to parameters when the <OBJECT> element is in  use.
Otherwise, LiveConnect won't work properly (MAYSCRIPT) with <OBJECT> elements.

Comment 18

[Michael Dunn]

Jud -- I am inclined to plus this for 094 based on Patrick's comment. Please
respond as appropriate.

Comment 19

[Judson Valeski]

per conversation w/ beard. minusing this for 0.9.4

Comment 20

[Patty Mac]

Verified on the commercial trunk:(2002-01-31-06-trunk)