10904 - mozilla/xpcom/sample needs updating

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P3)

Description

[Michael Ang]

- check factory example against warren's version
- nsSample CID is defined in nsISample.idl, bad!
- move stuff in README.html to xpconnect-sample.html

Comment 1

[Michael Ang]

- maybe add another implementation class to show that interfaces are not
one-to-one with implementations

Comment 2

[Michael Ang]

- get code review by scc or other

Comment 3

[Michael Ang]

Added mccabe, who may help me make this suck less.

- merged README.html into xpconnect-sample.html
- should wait for nsModule before changing factory code

Comment 4

[Mike McCabe]

Oho!

Adding more architect CCs.

Dear architects:  It's critically important that we get at least this one piece
of copiable boilerplate correct.  While doing so, I think we should avoid the
temptation to demonstrate everything.  The sample component should be a good
starting place for people coming to XPCOM.  If we want to demonstrate more
aspects, we should extend the sample in ways that don't distract from a simple
core.

We know that people copy and paste.  Let's get a good canonical place to copy
from.

Comment 5

[Mike McCabe]

Actually ccing those lucky folks.

Comment 6

[Mike McCabe]

Looks like travis isn't in the list.  Does he have a bugzilla id?

Comment 7

[Mike McCabe]

Adding Travis.

Comment 8

[Michael Ang]

Re-assigning to Travis, since he seems interested in fighting the good
fight.  (I'm outta here.)

Comment 9

[Warren Harris]

We should be sure to include the stuff in xpcom/build/nsConstructorPattern.cpp
to show how to have good factory hygiene, etc.

Comment 10

[don]

Move to M15.  This is not required for beta 1.

Comment 11

[travis]

This should probably live in DPs group....  Reassigning to him to assign to
someone else.

Comment 12

[Suresh Duddi (gone)]

scott, the sample is all yours.

Comment 13

[Scott Collins]

Another quick (I think) thing to fix between the hard problems.

Comment 14

[Scott Collins]

mass re-assigning to my new bugzilla account

Comment 15

[Suresh Duddi (gone)]

I am fixing this. Scott hope you wont mind if I take this one.

Comment 16

[Suresh Duddi (gone)]

Uses module code. Ah still doesnt do ProgID in header file.

Comment 17

[Michael Ang]

Attaching a patch that
- moves CID/ProgID into header file
- adds more calls to enablePrivilege
- renames "write" callback to something that works as intended

This makes things go on M15.  (I get "netscape is not defined" with M16; will
track this down.)

Comment 18

[Michael Ang]

Attachment: Proposed patch tested against M15

Comment 19

[Michael Ang]

patch checked in
r=scc

Comment 20

[Suresh Duddi (gone)]

Ok. So I can close this right. CODE fix.