109041 - SetWindow for windowless works differently between NS4.x and Mozilla

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[David Brittain]

For windowless plugins, in NS4.x, NPP_SetWindow(NPP instance, NPWindow* window) 
is called with the window->window member containing the hdc for drawing. This 
does not happen in Mozilla it is passed using PlatformHandleEvent
(nsPluginEvent* event) instead, so:

HDC hDC = reinterpret_cast<HDC>(event->wParam);

gets you the hdc.

Attached is a patch that fixes this problem.

Comment 1

[David Brittain]

Attachment: Initial patch

This works for me, our NS4.x windowless plugin now renders in Mozilla.

Comment 2

[David Brittain]

Adding cc.
Jeff, I think this is the same problem that you are seeing.

Comment 3

[av (gone)]

Comment on attachment 57010 [details] [diff] [review]
Initial patch

This makes sense. r=av

Comment 4

[Patrick C. Beard]

Comment on attachment 57010 [details] [diff] [review]
Initial patch

sr=beard

Comment 5

[av (gone)]

Checked in to the trunk. Do we want it in the branch as well?

Comment 6

[David Brittain]

Attachment: Zip file containing test files

Extract the zip file to a directory and copy the NS4.x windowless plugin
(NPSev22.dll) into the plugins directory. Open the html file
simplemozrobot.htm. This should also work on NS4.x although all the divs get
put in the wrong place. However, it shows that the plugin is rendering as
windowless in both NS4.x and Mozilla.

The test also highlights a bug, I'll open a new bug and post the number here.

Comment 7

[David Brittain]

Just entered bug 110094 for another problem with NS4.x windowless plugins.

I have verified that this bug is fixed with build 2001111303 on windows 2000.

Comment 8

[Peter Lubczynski]

Nominating for edt0.9.4 since this bug is part of the fix for bug 106435 which
is edt0.9.4+'ed.

Comment 9

[Judson Valeski]

please checkin to the 0.9.4 branch, and put "fixed0.9.4" in the keyword field
once it's in there; thanks!

Comment 10

[Peter Lubczynski]

Patch is now in the 0.9.4 branch.

Comment 11

[shrirang khanzode]

added keywd 'verified0.9.4'