1090444 - The Printing Progress dialog does not show progress or close when opened from the child process

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

When the Printing Progress dialog is opened in the child process (when kicking off a print in e10s, for example), it does not show progress, and doesn't close on its own when processing of the print job is complete.

This is because the plumbing to message the progress dialog in the parent process with progress data from the child hasn't been set up yet.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Ok, I think I've got a plan here:

I'm going to introduce a new IPC protocol "PPrintProgressDialog", and have it managed by PPrinting. That protocol will be used to channel progress updates from the child to the parent. The PPrintProgressDialogChild implementation will also implement the nsIWebProgressListener and nsIPrintProgressParams interfaces and be whats handed back to the showProgress caller. When the caller drops references to the PPrintProgressDialogChild (through those nsIWebProgressListener and nsIPrintProgressParams interfaces), on destruction, send a signal to the parent before destroying.

There's a little bit of lifetime management stuff to work out, but I think I can handle it. Expect some patches today.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: [WIP] The Printing Progress dialog does not show progress or close when opened from the child process. r=?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: [WIP] The Printing Progress dialog does not show progress or close when opened from the child process. r=?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: [WIP] The Printing Progress dialog does not show progress or close when opened from the child process. r=?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: The Printing Progress dialog does not show progress or close when opened from the child process. r=?

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8520174 [details] [diff] [review]
The Printing Progress dialog does not show progress or close when opened from the child process. r=?

Hey blassey - you reviewed the last chunk of printing platform work I did... did you want a crack at this too, or should I find another volunteer?

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 8520174 [details] [diff] [review]
The Printing Progress dialog does not show progress or close when opened from the child process. r=?

Review of attachment 8520174 [details] [diff] [review]:
-----------------------------------------------------------------

::: embedding/components/printingui/ipc/PPrintProgressDialog.ipdl
@@ +18,5 @@
> +
> +  ProgressChange(long curSelfProgress,
> +                       long maxSelfProgress,
> +                       long curTotalProgress,
> +                       long maxTotalProgress);

whitespace looks off

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Thanks,

remote:   https://hg.mozilla.org/integration/fx-team/rev/9a50f667e675

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9a50f667e675

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bugnotes

http://people.mozilla.org/~mconley2/bugnotes/bug-1090444.html