1090896 - Omitting data parameter in mozAlarms.add() method results in NS_ERROR_UNEXPECTED error

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Salvador de la Puente González [:salva]]

Attachment: Test application to show the NS_ERROR_UNEXPECTED error when `data` parameter is not provided

According to documentation [1], parameter `data` of `navigator.mozAlarms.add()` method is optional but omitting it results in NS_ERROR_UNEXPECTED error.

Please, find an attached demo app which demonstrates this issue. Observe the console output when tapping on the first button.

[1] https://developer.mozilla.org/en-US/docs/Web/API/MozAlarmsManager.add

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is a regression from bug 1015540 and bug 1037079.

The problem is that JSON.stringify(undefined) returns undefined, so JSON.parse(JSON.stringify(undefined)) throws.

We should skip the sandbox stuff if aData is undefined.... And clearly we need better tests here.

Comment 2

[Sean Lin [:seanlin] (inactive from Mar 2016)]

Attachment: Patch v1

Fixing the issue and adding correspondent tests.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8514042 [details] [diff] [review]
Patch v1

Thank you for writing the test.

>+    secondsLater.setSeconds(secondsLater.getSeconds() + 10);

Why 10, not 1 or 0.01?  There's no reason to wait for 10s here during a test run.

>+  SimpleTest.expectAssertions(0, 9);

Why are there assertions?  Because you reload the window?

I suggest avoiding the reloading business (which is liable to confuse the test harness badly) by running the parts of the test that depend on the permission bit in an iframe.  Add the permission, then load the iframe, which should then be able to do stuff with the alarms API.  That should work, no?

r=me with the tests fixed up

Comment 4

[Sean Lin [:seanlin] (inactive from Mar 2016)]

Attachment: Patch v2

Updating based on r+ comments.

Comment 5

[Sean Lin [:seanlin] (inactive from Mar 2016)]

The latest try-run. FYI.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ba3071481b06

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ca912d0526c

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0ca912d0526c