1090978 - enable --logcat-stdout for emulator builds

Status: RESOLVED WONTFIX

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

MnW is notorious for timing out and as a result, we don't get the logcats, so we can't diagnose what's wrong. This will interleave the relevant logcat lines between the test run output.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: emulatorstdout

testing this now on ash-mozharness

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8513507 [details]
emulatorstdout

looks good on ash: https://tbpl.mozilla.org/php/getParsedLog.php?id=51335158&tree=Ash&full=1#error19

Comment 3

[Jordan Lund (:jlund)]

Comment on attachment 8513507 [details]
emulatorstdout

lgtm :)

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

Thanks! landed in mozharness:
https://hg.mozilla.org/build/mozharness/rev/631924cf37da

Comment 5

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/mozharness/rev/631924cf37da

Comment 6

[Jordan Lund (:jlund)]

Comment on attachment 8513507 [details]
emulatorstdout

backed out on default:
https://hg.mozilla.org/build/mozharness/rev/533ac0171f3b

merged to production:
https://hg.mozilla.org/build/mozharness/rev/7bd43b2c5a88

15:54:53 <RyanVM|afk> jlund broke Marionette on older B2G release branches
15:55:02 <RyanVM|afk> https://treeherder.mozilla.org/ui/logviewer.html#?job_id=21303&repo=mozilla-b2g34_v2_1
15:55:11 <RyanVM|afk> fallout from bug 1090978
15:55:46 — jlund looks
15:57:03 <mdas> jlund: nah i have to uplift my marionette patch
15:57:07 <mdas> jlund: mind backing out the mozharness one?
15:57:29 <mdas> jlund: I have to uplift my mozilla-central patch to other versions of gecko

Comment 7

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: add --logcat-stdout to emulator runs

let's land this instead, now that the mozharness configs are in tree! \o/. Tries are green: 

desktop: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=e1d7ab2b556f

emulator: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b310e3012cda has fundamentally broken Mn runs, but you can now see interlaced logcat output, so we can fix that breakage! yay. https://ftp.mozilla.org/pub/mozilla.org/b2g/try-builds/[e-mail]-b310e3012cda/try-emulator/try_ubuntu64_vm-b2g-emulator_test-marionette-bm54-tests1-linux64-build288.txt.gz

Comment 8

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8526106 [details] [diff] [review]
add --logcat-stdout to emulator runs

Review of attachment 8526106 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure this is exactly what we want.

In the Mnw job, http://ftp.mozilla.org/pub/mozilla.org/b2g/try-builds/[e-mail]-b310e3012cda/try-emulator/try_ubuntu64_vm-b2g-emulator_test-marionette-webapi-bm67-tests1-linux64-build969.txt.gz, we do see the interleaved logcat, but unfortunately mozharness also dumps logcat, so we get the entire thing twice in the log, which is definitely suboptimal.

In the Mn job, we don't see the interleaved logcat from the harness at all (only from mozharness), because we fail to run any tests.

I think we want to implement this in such a way that we can omit the dump from mozharness, which means that the harness would always do it, even if there's some kind of startup failure.  Maybe we can detect whether http://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/runner/mixins/b2g.py#117 has ever been called when the harness exits, and if not, do a logcat dump at that time.

Comment 9

[[e-mail] (:bhearsum)]

Emulator builds are dead AFAIK