Closed Bug 1091010 Opened 8 years ago Closed 8 years ago

Optimize TypedObject.length in Ion

Categories

(Core :: JavaScript Engine: JIT, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Ion has functionality for computing the length of typed objects, but doesn't optimize .length accesses on them.  This is pretty easy to fix.  The main complexity is that accessing .length on a typed object when the buffer has been neutered will throw, instead of returning zero like on a typed array, which changes how we handle deoptimization when unsized arrays are neutered.  This change fits in well with the pending removal of unsized arrays anyhow.
Attachment #8513534 - Flags: review?(nmatsakis)
Attachment #8513534 - Flags: review?(nmatsakis) → review+
https://hg.mozilla.org/mozilla-central/rev/035c49aafe08
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.