1091025 - Enable play/ pause, previous, next and stop media AppCommands

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Mike de Boer [:mikedeboer]]

For the SoundCloud player I authored (see URL field), I'd like to provide support for Windows users to use the keyboard to control the player.

I'm not talking about exposing those keys to the Web right away, but simply allowing chrome to consume these key commands.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: enable play/ pause, previous, next and stop media AppCommands

Jim, if you're willing to review this patch, what would be a place to document this?

Comment 2

[Jim Mathies [:jimm]]

(In reply to Mike de Boer [:mikedeboer] from comment #1)
> Created attachment 8513554 [details] [diff] [review]
> Patch v1: enable play/ pause, previous, next and stop media AppCommands
> 
> Jim, if you're willing to review this patch, what would be a place to
> document this?

Don't think any of this is documented anywhere, we just rely on the app command code.

Comment 3

[Mike de Boer [:mikedeboer]]

Try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5319264b76d2

Comment 4

[Marco Mucci [:MarcoM]]

Added to IT 36.2

Comment 5

[Mike de Boer [:mikedeboer]]

Pushed to fx-team as: https://hg.mozilla.org/integration/fx-team/rev/5e90947eba69

Thanks Jim!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5e90947eba69

Comment 7

[Dietrich Ayala (:dietrich)]

Is there some documentation we can do to allow developers to hook into this? Adding the keyword preemptively.

Comment 8

[Jean-Yves Perrier [:teoli]]

Dietrich,

1. :-) It is never too early to add the keyword.
2. I see the APPCOMMAND on this page: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent.key
I don't know if we need more documentation that this. Asking :masayuki who is the expert about this page.

A related question about that page: how do we mark things available to chrome but not to Web sites, if there are some?

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Jean-Yves Perrier [:teoli] from comment #8)
> 2. I see the APPCOMMAND on this page:
> https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent.key
> I don't know if we need more documentation that this.

The document is about KeyboardEvent.key. Starting 37, Gecko for windows starts to dispatch key events at receiving WM_APPCOMMAND message if it's caused by key. Although, I'm not familiar with dispatchers of WM_APPCOMMAND, if e.g., mouse button causes the message, it could tell us the message isn't caused by key operation. In this case, only app-command event is fired. I.e., web apps cannot handle the events in this case.

So, app-command events are really different. They should be documented separately.

> A related question about that page: how do we mark things available to
> chrome but not to Web sites, if there are some?

I guess that all app command events should be listed here:
https://developer.mozilla.org/en-US/docs/Web/Events#Mozilla-specific_events
or here:
https://developer.mozilla.org/en-US/docs/Web/Events#Add-on-specific_events