Reduce the Robert Kieffer awesome uuid.js library (we only use the v4 to generate random UUIDs)

VERIFIED FIXED

Status

Firefox OS
Gaia::Loop
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: crdlc, Assigned: crdlc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobile app][Loop not in v1.1])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We are going to remove the Node.js specific parts of the code and the UUID version 1 generator (which we don't use)
(Assignee)

Updated

3 years ago
Assignee: nobody → crdlc
Blocks: 1088519
Status: NEW → ASSIGNED
Whiteboard: [mobile app]
(Assignee)

Comment 1

3 years ago
Created attachment 8513577 [details]
Github pull request

other one
Attachment #8513577 - Flags: review?(josea.olivera)
Comment on attachment 8513577 [details]
Github pull request

IMHO Let's keep third party libraries as they are. Lets discuss it if you disagree.
Attachment #8513577 - Flags: review?(josea.olivera)
(Assignee)

Comment 3

3 years ago
Tokbox does the same [1], I mean, they remove that code which won't be used for the app anymore. What is the rationale to have more code if this is not used? More code to parse means higher start-up time. IMHO we have to be faster and this point would be good. And also we could use instead of the whole uuid.js

var url = window.URL.createObjectURL(new Blob());
var uuid = url.replace('blob:', '');
window.URL.revokeObjectURL(url);

return uuid;

[1] See app/libs/tokbox/v2.2.9.1/js/TB.js

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #2)
> Comment on attachment 8513577 [details]
> Github pull request
> 
> IMHO Let's keep third party libraries as they are. Lets discuss it if you
> disagree.
Flags: needinfo?(josea.olivera)
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #2)
> Comment on attachment 8513577 [details]
> Github pull request
> 
> IMHO Let's keep third party libraries as they are. Lets discuss it if you
> disagree.

Agreed offline we are taking this patch. Thanks Cristian! Please, request review at me.
Flags: needinfo?(josea.olivera)
(Assignee)

Comment 5

3 years ago
Comment on attachment 8513577 [details]
Github pull request

10x
Attachment #8513577 - Flags: review?(josea.olivera)
Comment on attachment 8513577 [details]
Github pull request

LGTM. r=me

Thanks Cristian!
Attachment #8513577 - Flags: review?(josea.olivera) → review+
(Assignee)

Comment 7

3 years ago
Merged in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/1b810de2ee33a8cc0a2833579428ea6f4e812453
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [mobile app] → [mobile app][Loop not in v1.1]
Tested. Loop applications still is working with this update
Flame
user
v2.0
Gecko-05f9775
Gaia-d3e4da3
Loop version: master , dd4862e
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.