1091038 - Reduce the Robert Kieffer awesome uuid.js library (we only use the v4 to generate random UUIDs)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Cristian Rodriguez (:crdlc)]

We are going to remove the Node.js specific parts of the code and the UUID version 1 generator (which we don't use)

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

other one

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8513577 [details]
Github pull request

IMHO Let's keep third party libraries as they are. Lets discuss it if you disagree.

Comment 3

[Cristian Rodriguez (:crdlc)]

Tokbox does the same [1], I mean, they remove that code which won't be used for the app anymore. What is the rationale to have more code if this is not used? More code to parse means higher start-up time. IMHO we have to be faster and this point would be good. And also we could use instead of the whole uuid.js

var url = window.URL.createObjectURL(new Blob());
var uuid = url.replace('blob:', '');
window.URL.revokeObjectURL(url);

return uuid;

[1] See app/libs/tokbox/v2.2.9.1/js/TB.js

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #2)
> Comment on attachment 8513577 [details]
> Github pull request
> 
> IMHO Let's keep third party libraries as they are. Lets discuss it if you
> disagree.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #2)
> Comment on attachment 8513577 [details]
> Github pull request
> 
> IMHO Let's keep third party libraries as they are. Lets discuss it if you
> disagree.

Agreed offline we are taking this patch. Thanks Cristian! Please, request review at me.

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8513577 [details]
Github pull request

10x

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8513577 [details]
Github pull request

LGTM. r=me

Thanks Cristian!

Comment 7

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/1b810de2ee33a8cc0a2833579428ea6f4e812453

Comment 8

[Loli (:lolimartinezcr)]

Tested. Loop applications still is working with this update
Flame
user
v2.0
Gecko-05f9775
Gaia-d3e4da3
Loop version: master , dd4862e