1091261 - Implement login 3.0 in Appmaker

Status: RESOLVED FIXED

(Webmaker Graveyard :: General, defect)

Comment 1

[Simon Wex :wex]

Hey jbuck, Chris, I see this one isn't in progress. How are the implementation docs for someone not familiar with Login3?

Comment 2

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/webmaker-login-ux/pull/49

Some docs for Scott!

Comment 3

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla-appmaker/appmaker/pull/2355

Here's all of the work needed to make login 3 work, from an API point of view. Still a lot of work that needs to be done to make it look right...

Comment 4

[Jon Buckley [:jbuck]]

Comment on attachment 8517758 [details] [review]
https://github.com/mozilla-appmaker/appmaker/pull/2355

ignore all of the changes in /public/vendor, it's actually a fairly tiny review.

Comment 5

[Chris DeCairos (:cade)]

Comment on attachment 8517758 [details] [review]
https://github.com/mozilla-appmaker/appmaker/pull/2355

One missing semi colon and Travis is failing the build due to the new param webmaker-auth needs, but otherwise this looks great!

Comment 6

[Pomax]

Comment on attachment 8517758 [details] [review]
https://github.com/mozilla-appmaker/appmaker/pull/2355

number of issues in the patch - also this needs to be landed in parts.

Comment 7

[Pomax]

Comment on attachment 8517758 [details] [review]
https://github.com/mozilla-appmaker/appmaker/pull/2355

super win after fixes. r+ and merged