Implement login 3.0 in Appmaker

RESOLVED FIXED

Status

Webmaker
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jbuck, Assigned: jbuck)

Tracking

Details

(Whiteboard: [nov14] [login3])

Attachments

(2 attachments)

Comment hidden (empty)

Comment 1

4 years ago
Hey jbuck, Chris, I see this one isn't in progress. How are the implementation docs for someone not familiar with Login3?
Flags: needinfo?(jon)
Flags: needinfo?(cade)
(Assignee)

Comment 2

4 years ago
Created attachment 8514367 [details] [review]
https://github.com/mozilla/webmaker-login-ux/pull/49

Some docs for Scott!
Flags: needinfo?(jon)
Flags: needinfo?(cade)
Attachment #8514367 - Flags: review?(scott)
(Assignee)

Updated

4 years ago
Assignee: nobody → scott
Status: NEW → ASSIGNED
Assignee: scott → pomax
(Assignee)

Updated

4 years ago
Assignee: pomax → jon
(Assignee)

Comment 3

4 years ago
Created attachment 8517758 [details] [review]
https://github.com/mozilla-appmaker/appmaker/pull/2355

Here's all of the work needed to make login 3 work, from an API point of view. Still a lot of work that needs to be done to make it look right...
(Assignee)

Updated

4 years ago
Attachment #8514367 - Flags: review?(scott)
(Assignee)

Comment 4

4 years ago
Comment on attachment 8517758 [details] [review]
https://github.com/mozilla-appmaker/appmaker/pull/2355

ignore all of the changes in /public/vendor, it's actually a fairly tiny review.
Attachment #8517758 - Flags: review?(pomax)
Attachment #8517758 - Flags: review?(cade)
Comment on attachment 8517758 [details] [review]
https://github.com/mozilla-appmaker/appmaker/pull/2355

One missing semi colon and Travis is failing the build due to the new param webmaker-auth needs, but otherwise this looks great!
Attachment #8517758 - Flags: review?(cade) → review+
(Assignee)

Updated

4 years ago
Whiteboard: [nov14] [login3]

Comment 6

4 years ago
Comment on attachment 8517758 [details] [review]
https://github.com/mozilla-appmaker/appmaker/pull/2355

number of issues in the patch - also this needs to be landed in parts.
Attachment #8517758 - Flags: review?(pomax) → review-

Comment 7

4 years ago
Comment on attachment 8517758 [details] [review]
https://github.com/mozilla-appmaker/appmaker/pull/2355

super win after fixes. r+ and merged
Attachment #8517758 - Flags: review- → review+
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.