Closed
Bug 1091303
Opened 11 years ago
Closed 8 years ago
Get new message strings for camera/video added to 2.1
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: hkoka, Unassigned)
Details
Follow up from bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1079543
Opening bug to cherry pick translated strings for the new message that got added and cherry pick them into 2.1 branch.
| Reporter | ||
Comment 1•11 years ago
|
||
Strings names to be cherry picked:
camera-unavailable-title
camera-unavailable-text
| Reporter | ||
Updated•11 years ago
|
Assignee: nobody → hkoka
Comment 2•11 years ago
|
||
(In reply to Hema Koka [:hema] from comment #0)
> Opening bug to cherry pick translated strings for the new message that got
> added and cherry pick them into 2.1 branch.
Can you explain what "cherry pick" means for you in practical terms (i.e. what you plan to do)?
| Reporter | ||
Comment 3•11 years ago
|
||
Update:
Given where we are in the 2.1 release cycle and way past the string freeze deadline, Zibi's suggestion is the better option that we have got...
here it is from email thread...
It would be much easier to:
- open 2.2 for localization
- wait some time (seems like we have time?)
- see how many locales did translate the string (hopefully most of the
major ones)
- cherry-pick this string into 2.1 from the locale with a fallback to
en-US
By cherry pick, the specific translated strings that is needed are picked from master and added to 2.1 files containing string translations.
After speaking to Flod on IRC, since touching l10n files will interfere with external tools, he suggested to wait for 2.1 and master translations to go through and eventually think about moving strings. Stephany (Product) is okay with message being in English for untranslated languages in 2.1 per comments in original bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1079543
So far, we have localizations for fr and it only : http://transvision.mozfr.org/string/?entity=apps/camera/camera.properties:camera-unavailable-title&repo=gaia
Thanks
Hema
| Reporter | ||
Comment 4•11 years ago
|
||
Attaching alternate low impact proposal from Zibi/Stas from email:
We will introduce a new, temporary file - late.{locale}.properties.
When we can pick the strings from locale repositories from master branches, we will create late.ab-CD.properties file in the source repository on 2.1 branch.
- for source/en-US, nothing changes. The only thing we need on 2.1 is an addition of '@import url(late.en-US.properties)'[0] in locales.ini for those two apps.
- we land the en-US strings in their respective resource file
- when we have the strings in a locale master branch, we copy them into late.ab-CD.properties file in the gaia repo, 2.1 branch
At build time we load all available files and merge them into ab-CD.json resource. For en-US those strings will be taken from their respective resource files. For ab-CD, they will be taken from late.ab-CD.properties.
This means no need to break string freeze, no changes to locale repositories, no threat to our release systems.
All we need is the addition of the line in Video/Gallery locales.ini and someone to write a script to take two strings from locales HG repositories and push them to the late.ab-CD.properties file in the 2.1 gaia branch.
| Reporter | ||
Comment 5•11 years ago
|
||
Justin/Russ,
Can one of you please help with the script and camera/video locales.ini change mentioned in previous comment. If you have any questions, ping Zibi or Stats.
Thanks
Hema
Assignee: hkoka → nobody
Flags: needinfo?(rnicoletti)
Flags: needinfo?(jdarcangelo)
| Reporter | ||
Updated•11 years ago
|
Summary: Cherry Pick Translated strings for "camera-unavailable" from master into 2.1 → Get new message strings for camera/video added to 2.1
Comment 6•11 years ago
|
||
Hi Zibi, I am not completely clear on the solution in Hema's comment 4. My main lack of understanding comes from the fact that there is a properties file per locale and in the solution a single late.ab-CD.properties file is mentioned. As I understand it, at build time, the localized strings are packaged as <locale>.json resource files; one file per locale. How would it work to have a single late.ab-CD.properties file and a single ab-CD.json resource file? Would we not need "late" files per locale? Thanks in advance for the clarification.
Flags: needinfo?(rnicoletti) → needinfo?(gandalf)
Comment 7•11 years ago
|
||
Cancelling NI for Zibi. I found more information here: https://bugzilla.mozilla.org/show_bug.cgi?id=1095686#c3
Flags: needinfo?(gandalf)
Comment 8•10 years ago
|
||
Bulk-clearing old NI? requests. If this still needs my attention, please re-flag me. Thanks.
Flags: needinfo?(jdarcangelo)
Comment 9•8 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•