Legacy sync "change password" and "recovery key" options don't work with incontent prefs

RESOLVED FIXED in Firefox 35

Status

()

Firefox
Sync
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

unspecified
Firefox 36
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8513945 [details] [diff] [review]
0006-Bug-XXXXXXX-fix-legacy-sync-password-and-passphrase-.patch

With legacy sync configured, go to incontent sync prefs and select the options "My recovery key" or "change password".

Expected: you can view your recovery key or change your password.
Actual: Noting happens and console reports "JavaScript error: chrome://browser/content/sync/utils.js, line 69: TypeError: this.openChange is not a function"

Introduced via bug 1016300 and fixed by the attached patch.  I could have used .bind() but thought an inline function slightly cleaner.

Setting qeverify- as I think we can verify this manually while working on sync migration.
Attachment #8513945 - Flags: review?(adw)
Flags: qe-verify-
Flags: firefox-backlog+

Updated

3 years ago
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Iteration: --- → 36.2

Updated

3 years ago
Attachment #8513945 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/174edfcaa3d1
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Sounds like this needs to hit Firefox 34/35, right? Can you get the approval requests in ASAP.
status-firefox34: --- → affected
status-firefox35: --- → affected
status-firefox36: --- → fixed
tracking-firefox34: --- → +
tracking-firefox35: --- → +
tracking-firefox36: --- → +
Flags: needinfo?(mhammond)
Oh, nevermind - in-content prefs only.
status-firefox34: affected → ---
status-firefox35: affected → ---
status-firefox36: fixed → ---
tracking-firefox34: + → ---
tracking-firefox35: + → ---
tracking-firefox36: + → ---
Flags: needinfo?(mhammond)
Comment on attachment 8513945 [details] [diff] [review]
0006-Bug-XXXXXXX-fix-legacy-sync-password-and-passphrase-.patch

Though actually we probably should get this on Aurora given that bug 1072181 enables in-content prefs there.
Attachment #8513945 - Flags: approval-mozilla-aurora+
status-firefox35: --- → affected
https://hg.mozilla.org/releases/mozilla-aurora/rev/056a21b111cc
status-firefox35: affected → fixed
status-firefox36: --- → fixed
You need to log in before you can comment on or make changes to this bug.