Closed Bug 1091320 Opened 9 years ago Closed 9 years ago

Legacy sync "change password" and "recovery key" options don't work with incontent prefs

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 36
Iteration:
36.2
Tracking Flags:
Tracking Status
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: markh, Assigned: markh)

References

Details

Attachments

(1 file)

0006-Bug-XXXXXXX-fix-legacy-sync-password-and-passphrase-.patch
1.52 KB, patch
adw
: review+
Gavin
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
With legacy sync configured, go to incontent sync prefs and select the options "My recovery key" or "change password".

Expected: you can view your recovery key or change your password.
Actual: Noting happens and console reports "JavaScript error: chrome://browser/content/sync/utils.js, line 69: TypeError: this.openChange is not a function"

Introduced via bug 1016300 and fixed by the attached patch.  I could have used .bind() but thought an inline function slightly cleaner.

Setting qeverify- as I think we can verify this manually while working on sync migration.
Attachment #8513945 - Flags: review?(adw)
Flags: qe-verify-
Flags: firefox-backlog+
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Iteration: --- → 36.2
Attachment #8513945 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/174edfcaa3d1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Sounds like this needs to hit Firefox 34/35, right? Can you get the approval requests in ASAP.
status-firefox34: --- → affected
status-firefox35: --- → affected
status-firefox36: --- → fixed
tracking-firefox34: --- → +
tracking-firefox35: --- → +
tracking-firefox36: --- → +
Flags: needinfo?(mhammond)
Oh, nevermind - in-content prefs only.
status-firefox34: affected → ---
status-firefox35: affected → ---
status-firefox36: fixed → ---
tracking-firefox34: + → ---
tracking-firefox35: + → ---
tracking-firefox36: + → ---
Flags: needinfo?(mhammond)
Comment on attachment 8513945 [details] [diff] [review]
0006-Bug-XXXXXXX-fix-legacy-sync-password-and-passphrase-.patch

Though actually we probably should get this on Aurora given that bug 1072181 enables in-content prefs there.
Attachment #8513945 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.