1091321 - Convert all the SVG functions that take an nsRenderingContext to take a gfxContext instead

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: ApplyClipOrPaintClipMask

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: PaintFramesWithEffects

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: PaintFilteredFrame

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: PaintSVG

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: PaintMark

Comment 6

[Jonathan Watt [:jwatt]]

Attachment: PaintFramesWithEffects

Comment 7

[Jonathan Watt [:jwatt]]

Attachment: PaintFrameWithEffects

Comment 8

[Jonathan Watt [:jwatt]]

Attachment: nsSVGFilterPaintCallback

Comment 9

[Robert Longson [:longsonr]]

Comment on attachment 8513946 [details] [diff] [review]
ApplyClipOrPaintClipMask

Review of attachment 8513946 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxContext.cpp
@@ +683,5 @@
> +  AzureState::PushedClip clip = { aPath, Rect(), mTransform };
> +  CurrentState().pushedClips.AppendElement(clip);
> +}
> +
> +void

Duplicates the second half of gfxContext::Clip(). Perhaps gfxContext::Clip() should call this. And the rect clip above should be called by gfxContext::Clip() rather than calling it for consistency.

Also while you're here you might change the rect clip argument above to be aRect.

::: gfx/thebes/gfxContext.h
@@ +504,5 @@
>       * Any current path will be destroyed by these functions!
>       */
>      void Clip(const Rect& rect);
>      void Clip(const gfxRect& rect); // will clip to a rect
> +    void Clip(Path* aPath);

aPath should be const

Comment 10

[Jonathan Watt [:jwatt]]

(In reply to Robert Longson from comment #9)
> ::: gfx/thebes/gfxContext.cpp
> @@ +683,5 @@
> > +  AzureState::PushedClip clip = { aPath, Rect(), mTransform };
> > +  CurrentState().pushedClips.AppendElement(clip);
> > +}
> > +
> > +void
> 
> Duplicates the second half of gfxContext::Clip(). Perhaps gfxContext::Clip()
> should call this. And the rect clip above should be called by
> gfxContext::Clip() rather than calling it for consistency.
> 
> Also while you're here you might change the rect clip argument above to be
> aRect.

This code originally came from bug 1090614 but I moved it here because I thought I'd land this first. That didn't happen though because this bug is still blocked on review in bug 651021. When I landed 1090614 I forgot to move the Clip changes back to the patches there, which broke the tree. I then landed them in a hurry to fix the bustage without addressing the comments here. Since we hope to have killed off gfxContext in the next 6-12 months I don't think we care about keeping it really neat and tidy though.

> ::: gfx/thebes/gfxContext.h
> @@ +504,5 @@
> >       * Any current path will be destroyed by these functions!
> >       */
> >      void Clip(const Rect& rect);
> >      void Clip(const gfxRect& rect); // will clip to a rect
> > +    void Clip(Path* aPath);
> 
> aPath should be const

It can't be, since the state stack keeps pointer s to non-const. Besides that Path objects are immutable anyway.

Comment 11

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e84b632bc007
https://hg.mozilla.org/integration/mozilla-inbound/rev/1653558849c3
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc72e58dd4c2
https://hg.mozilla.org/integration/mozilla-inbound/rev/3313505b1b0e
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddc50e4998ca
https://hg.mozilla.org/integration/mozilla-inbound/rev/67f94bf87c7c
https://hg.mozilla.org/integration/mozilla-inbound/rev/544fe2d91fcd

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e84b632bc007
https://hg.mozilla.org/mozilla-central/rev/1653558849c3
https://hg.mozilla.org/mozilla-central/rev/dc72e58dd4c2
https://hg.mozilla.org/mozilla-central/rev/3313505b1b0e
https://hg.mozilla.org/mozilla-central/rev/ddc50e4998ca
https://hg.mozilla.org/mozilla-central/rev/67f94bf87c7c
https://hg.mozilla.org/mozilla-central/rev/544fe2d91fcd