Closed
Bug 109134
Opened 23 years ago
Closed 23 years ago
optimize mailHeaders.css to improve message display
Categories
(SeaMonkey :: MailNews: Message Display, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.7
People
(Reporter: mscott, Assigned: mscott)
References
Details
(Keywords: perf)
Attachments
(1 file)
2.61 KB,
patch
|
Bienvenu
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
I'm sure there are some style rules which can be written differently in
mailHeaders.css that will help reduce style resolution time which is a hot spot
during message display.
Assignee | ||
Comment 1•23 years ago
|
||
accepting
Assignee | ||
Comment 2•23 years ago
|
||
Comment 3•23 years ago
|
||
Are you sure this is faster? Why? Without the label identifier, the class can
apply to any element.
Comment 4•23 years ago
|
||
Okay, Joe thinks it's faster, but please make sure things still look okay with
the message header in classic and modern. While doing the xul syntax changes, I
seem to recall |label| being needed for some odd reason, else things either
weren't bold or had the wrong margin.
Assignee | ||
Comment 5•23 years ago
|
||
hyatt sayz...."just class names are faster because we look that up first". If
you specify a tag as well then after the class look up we have to check and make
sure the tag matches too.
Updated•23 years ago
|
Comment 6•23 years ago
|
||
Comment on attachment 57099 [details] [diff] [review]
not many style rules written incorrectly...but here's the optmization.
r=bienvenu
Attachment #57099 -
Flags: review+
Assignee | ||
Comment 7•23 years ago
|
||
Comment on attachment 57099 [details] [diff] [review]
not many style rules written incorrectly...but here's the optmization.
i got a rs=sspitzer on this
Attachment #57099 -
Flags: superreview+
Assignee | ||
Comment 8•23 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
QA Contact: esther → stephend
I've verified that message display speed has improved (pretty nicely, I might
add). Too many good fixes landed in the same time frame for me to single out
which improved it specifically. See
http://www.mozilla.org/mailnews/win_performance_results.html for more details.
Verified FIXED.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•