Closed Bug 109134 Opened 23 years ago Closed 23 years ago

optimize mailHeaders.css to improve message display

Categories

(SeaMonkey :: MailNews: Message Display, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.7

People

(Reporter: mscott, Assigned: mscott)

References

Details

(Keywords: perf)

Attachments

(1 file)

I'm sure there are some style rules which can be written differently in mailHeaders.css that will help reduce style resolution time which is a hot spot during message display.
accepting
Blocks: 22960
Status: NEW → ASSIGNED
Keywords: nsbeta1, perf
Target Milestone: --- → mozilla0.9.7
Are you sure this is faster? Why? Without the label identifier, the class can apply to any element.
Okay, Joe thinks it's faster, but please make sure things still look okay with the message header in classic and modern. While doing the xul syntax changes, I seem to recall |label| being needed for some odd reason, else things either weren't bold or had the wrong margin.
hyatt sayz...."just class names are faster because we look that up first". If you specify a tag as well then after the class look up we have to check and make sure the tag matches too.
Keywords: nsbeta1nsbeta1+
Comment on attachment 57099 [details] [diff] [review] not many style rules written incorrectly...but here's the optmization. r=bienvenu
Attachment #57099 - Flags: review+
Comment on attachment 57099 [details] [diff] [review] not many style rules written incorrectly...but here's the optmization. i got a rs=sspitzer on this
Attachment #57099 - Flags: superreview+
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
QA Contact: esther → stephend
I've verified that message display speed has improved (pretty nicely, I might add). Too many good fixes landed in the same time frame for me to single out which improved it specifically. See http://www.mozilla.org/mailnews/win_performance_results.html for more details. Verified FIXED.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: