1091353 - [Stingray] Home key and Power key should be only handled by System App

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

KeyboardEvents will be sent to Gaia after Bug 989198 is landed.

Some keys can be handled by foreground App to customize the behaviour, and some should be preserved by System App since they are used for critical functionalities. For example, Home key and Power key.

For more information, please refer to https://wiki.mozilla.org/WebAPI/BrowserAPI/KeyboardEvent

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Without fixing this issue, something strange like bug 1084187 will happen.

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

My plan is to have a workaround to call evt.preventDefault() in system app when receiving 'mozbrowserkeydown' and 'keydown' of following key:
1. Power
2. Exit
3. Home

Comment 3

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Until bug 1014418 lands, we need this fix, otherwise bug 989198 might get backed out because of issue like bug 1084187. 
And reviewer of bug 1014418 refuse to review the patch of bug 1014418 until bug 989198 lands. That's why we need this workaround for now.

I'll remove this workaround once bug 1014418 lands.

Comment 4

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

Once bug 989198 lands, all app could receive 'keydown' event, which may cause strange behavior until bug 1014418 lands. This patch call preventDefault() on receiving mozbrowserbeforekeydown and keydown event of Power, Exit, and Home key. This patch should be removed when bug 1014418 lands.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8514010 [details] [review]
pull request

I was thinking maybe the workaround should be a standalone class that can be easily removed, but since it's going to be short lived let's put it this way for now.

Thanks!

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Thanks,

gaia try looks good now 
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=747c2022e858

land this on master
https://github.com/mozilla-b2g/gaia/commit/22fd0ab3090300972a0ff8c7a08f4ed31f00eeb1