1091383 - Move delayload logic entirely in moz.build frontend code

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Move delayload logic entirely in moz.build frontend code

Please tell me if you think it's worth the bother to test the OS_TARGET != WINNT case.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8514028 [details] [diff] [review]
Move delayload logic entirely in moz.build frontend code

Review of attachment 8514028 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/frontend/emitter.py
@@ +413,5 @@
>              if v in context and context[v]:
>                  passthru.variables[v] = context[v]
>  
> +        if context.config.substs.get('OS_TARGET') == 'WINNT' and \
> +                context['DELAYLOAD_DLLS']:

I think having the OS_TARGET == WINNT here is fine and is what should be done.

Do you intend to go back and update moz.build files to move the DELAYLOAD_DLL assignments out from under a == WINNT check?

Comment 3

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #2)
> Do you intend to go back and update moz.build files to move the
> DELAYLOAD_DLL assignments out from under a == WINNT check?

I'll leave that to a followup. (or not, I have possible alternative ideas)

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/772ac2d0189c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/772ac2d0189c