Closed Bug 1091383 Opened 5 years ago Closed 5 years ago

Move delayload logic entirely in moz.build frontend code

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

No description provided.
Please tell me if you think it's worth the bother to test the OS_TARGET != WINNT case.
Attachment #8514028 - Flags: review?(gps)
Comment on attachment 8514028 [details] [diff] [review]
Move delayload logic entirely in moz.build frontend code

Review of attachment 8514028 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/frontend/emitter.py
@@ +413,5 @@
>              if v in context and context[v]:
>                  passthru.variables[v] = context[v]
>  
> +        if context.config.substs.get('OS_TARGET') == 'WINNT' and \
> +                context['DELAYLOAD_DLLS']:

I think having the OS_TARGET == WINNT here is fine and is what should be done.

Do you intend to go back and update moz.build files to move the DELAYLOAD_DLL assignments out from under a == WINNT check?
Attachment #8514028 - Flags: review?(gps) → review+
(In reply to Gregory Szorc [:gps] from comment #2)
> Do you intend to go back and update moz.build files to move the
> DELAYLOAD_DLL assignments out from under a == WINNT check?

I'll leave that to a followup. (or not, I have possible alternative ideas)
https://hg.mozilla.org/mozilla-central/rev/772ac2d0189c
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Blocks: 1096109
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.