1091445 - Add video and audio codec used in loop in Telemetry reports

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Oscar Patiño González]

It is needed to add the audio and video codec names that are being used in Loop, and send these statistics to Telemetry server

Comment 1

[Oscar Patiño González]

Attachment: proposed patch

Comment 2

[Oscar Patiño González]

Comment on attachment 8514938 [details] [review]
proposed patch

Added modification as Carmen Jimenez suggested

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8514938 [details] [review]
proposed patch

Left a few comments on the PR. Have a look at them please. Thanks Oscar.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Well, the code is ready to go. Oscar, since there is no a frontend (AFAIK) for checking what the client sent to the server I'm assuming you deployed a local server and checked it. If not I encourage you to deploy it. Find more information at https://github.com/mozilla/telemetry-server please.

The input of Mark will be great. Mark we are adding the names for the A/V codec used in the WebRTC call. We are adding a couple of arrays containing the name of the codes. Would you mind to have a look please?

Comment 5

[Mark Reid [:mreid]]

This looks fine to me.

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8514938 [details] [review]
proposed patch

(In reply to Mark Reid [:mreid] from comment #5)
> This looks fine to me.

Thanks Mark! Oscar, lets land this. Thanks!

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Landed on master branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/1dd13b68b88242fafc3af326bda859572d64f2a1

Thanks for your work here Oscar!