1091528 - [B2G][RIL] when receiving 'rilRequestType: 12', Error: Don't know about this message type: undefined" {file: "jar:file:///system/b2g/omni.ja!/components/RadioInterfaceL ayer.js" line: 1961}]

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

I/Gecko   ( 7478): -*- RadioInterface[0]: Received message from worker: {"rilRequestType":12,"rilRequestError":0,"success":true,"errorMsg":null,"rilMessageClientId     ":0}
W/GeckoConsole( 7478): [JavaScript Error: "Error: Don't know about this message type: undefined" {file: "jar:file:///system/b2g/omni.ja!/components/RadioInterfaceL     ayer.js" line: 1961}]


STR:Hang up a single call

root cause in [1]: we should keep options (specifically, rilMessageToken) because in [2] we will determine unsolicited message type by "rilMessageToken." 
[3] might sendChromeMessage without rilMessageToken that causes this error.

[1] dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js?from=ril_worker.js#5469
[2] http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js?from=RadioInterfaceLayer.js#1572
[3] http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js?from=ril_worker.js#5469

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #0)
> I/Gecko   ( 7478): -*- RadioInterface[0]: Received message from worker:
> {"rilRequestType":12,"rilRequestError":0,"success":true,"errorMsg":null,
> "rilMessageClientId     ":0}
> W/GeckoConsole( 7478): [JavaScript Error: "Error: Don't know about this
> message type: undefined" {file:
> "jar:file:///system/b2g/omni.ja!/components/RadioInterfaceL     ayer.js"
> line: 1961}]
> 
> 
> STR:Hang up a single call
> 
> root cause in [1]: we should keep options (specifically, rilMessageToken)
> because in [2] we will determine unsolicited message type by
> "rilMessageToken." 
> [3] might sendChromeMessage without rilMessageToken that causes this error.
> 
> [1]
> dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.
> js?from=ril_worker.js#5469

[1] should be here: http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js?from=ril_worker.js#1776

> [2]
> http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/
> RadioInterfaceLayer.js?from=RadioInterfaceLayer.js#1572
> [3]
> http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.
> js?from=ril_worker.js#5469

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: WIP

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: WIP

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/70f2c7eabb86

Comment 5

[(Away)]

In your commit messages, please describe the code change, not the bug symptom. Thanks.

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to :dmajor (back November 3) from comment #5)
> In your commit messages, please describe the code change, not the bug
> symptom. Thanks.

Thanks, will do next time.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/70f2c7eabb86