1091711 - styling wrong for tab controls

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Tom Tromey :tromey]

Attachment: "Ok" styling showing just the "+" control.

The tab controls in the new theme are styled incorrectly for me.

When I have just a few tabs and only the "+" is visible,
the styling looks ok.

However when I have many tabs, the styling is incorrect.

Also the menu bar is not using the new style; but Paul said that
maybe this is intentional.

I'll attach screen shots of the tab control styling.

Comment 1

[Tom Tromey :tromey]

Attachment: screenshot showing the incorrect styling

Comment 2

[Tim Nguyen :ntim]

I'm also noticing in this screenshot that the new tab icon isn't inverted.

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to Tim Nguyen [:ntim] from comment #2)
> I'm also noticing in this screenshot that the new tab icon isn't inverted.

I think that's because it's using the stock icons for the OS: moz-icon://stock/gtk-add?size=menu.  I have a hunch there is a bug opened to switch to the Firefox new tab icon for this, but I can't find it at the moment.  Going to let that be for now.

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Tom Tromey :tromey from comment #0)
> Created attachment 8514369 [details]
> "Ok" styling showing just the "+" control.
> 
> The tab controls in the new theme are styled incorrectly for me.
> 
> When I have just a few tabs and only the "+" is visible,
> the styling looks ok.
> 
> However when I have many tabs, the styling is incorrect.
> 
> Also the menu bar is not using the new style; but Paul said that
> maybe this is intentional.
> 
> I'll attach screen shots of the tab control styling.

Thanks for the report, I believe I have a fix for this and will include it in the next revision of the patch.

Comment 5

[Paul Rouget [:paul]]

(In reply to Brian Grinstead [:bgrins] from comment #4)
> (In reply to Tom Tromey :tromey from comment #0)
> > Created attachment 8514369 [details]
> > "Ok" styling showing just the "+" control.
> > 
> > The tab controls in the new theme are styled incorrectly for me.
> > 
> > When I have just a few tabs and only the "+" is visible,
> > the styling looks ok.
> > 
> > However when I have many tabs, the styling is incorrect.
> > 
> > Also the menu bar is not using the new style; but Paul said that
> > maybe this is intentional.
> > 
> > I'll attach screen shots of the tab control styling.
> 
> Thanks for the report, I believe I have a fix for this and will include it
> in the next revision of the patch.

Is it fixed?

Comment 6

[Tom Tromey :tromey]

> Is it fixed?

It works for me with today's.

Comment 7

[Cornel Ionce [:noni] [Hubs QA]]

Marking verified based on comment 6.