Closed Bug 1091758 Opened 5 years ago Closed 5 years ago

Add relative path to filenames in BHR data.

Categories

(Toolkit :: Telemetry, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: rvitillo, Assigned: jchen)

Details

Attachments

(1 file)

Currently BHR telemetry data contains only the filenames for functions executed in javascript contexts, e.g.:

['Startup::XRE_Main', 'nsInputStreamPump::OnInputStreamReady', 'nsInputStreamPump::OnStateTransfer', 'nsHttpChannel::OnDataAvailable', 'AdblockPopups.jsm:1523', 'PdfStreamConverter.jsm:837’]

As we would like to correlate addons to BHR data, it would be great to have also the relative path of javascript files in order to avoid name clashes and to  identify to which add-on a file belongs to.

Jim, would that be possible?
Flags: needinfo?(nchen)
Something similar was done for main-thread IO reporting.. all paths were reported relative to profile directory or binary install directory
Sorry, just got back from PTO.

It's definitely possible. The lines at [1] strip the full script path down to the base name. This was done to save space in the telemetry ping, but we can certainly keep the full path if that makes it easier to identify addons.

[1] http://mxr.mozilla.org/mozilla-central/source/xpcom/threads/ThreadStackHelper.cpp?rev=0c66a9fd9085#552
Flags: needinfo?(nchen)
Assignee: nobody → nchen
Status: NEW → ASSIGNED
This patch makes us report full paths so we can differentiate add-ons.
Attachment #8526950 - Flags: review?(snorp)
Attachment #8526950 - Flags: review?(snorp) → review+
https://hg.mozilla.org/mozilla-central/rev/de95782a7939
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.