1091758 - Add relative path to filenames in BHR data.

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Roberto Agostino Vitillo (:rvitillo)]

Currently BHR telemetry data contains only the filenames for functions executed in javascript contexts, e.g.:

['Startup::XRE_Main', 'nsInputStreamPump::OnInputStreamReady', 'nsInputStreamPump::OnStateTransfer', 'nsHttpChannel::OnDataAvailable', 'AdblockPopups.jsm:1523', 'PdfStreamConverter.jsm:837’]

As we would like to correlate addons to BHR data, it would be great to have also the relative path of javascript files in order to avoid name clashes and to  identify to which add-on a file belongs to.

Jim, would that be possible?

Comment 1

[Vladan Djeric (:vladan)]

Something similar was done for main-thread IO reporting.. all paths were reported relative to profile directory or binary install directory

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Sorry, just got back from PTO.

It's definitely possible. The lines at [1] strip the full script path down to the base name. This was done to save space in the telemetry ping, but we can certainly keep the full path if that makes it easier to identify addons.

[1] http://mxr.mozilla.org/mozilla-central/source/xpcom/threads/ThreadStackHelper.cpp?rev=0c66a9fd9085#552

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Report full paths for most chrome scripts (v1)

This patch makes us report full paths so we can differentiate add-ons.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

https://tbpl.mozilla.org/?tree=Try&rev=a574f10a0327

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/de95782a7939

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/de95782a7939