Closed Bug 1091884 Opened 10 years ago Closed 10 years ago

Status icon height too big in MUCs

Categories

(Instantbird Graveyard :: Conversation, defect)

Product:
Instantbird Graveyard
Component:
Conversation
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: aleth, Assigned: aleth)

References

Details

(Keywords: regression)

Attachments

(2 files)

Screenshot.png
14.66 KB, image/png
Details
iconheight.diff
737 bytes, patch
clokep
: review+
Details | Diff | Splinter Review
Attached image Screenshot.png — 
See screenshot (19px not 16px). Probably crept in with the generic toolbar icon patch.
Attached patch iconheight.diff — — Splinter Review 

        Attachment #8514593 -
        Flags: review?(clokep)

    
    

    
  
Comment on attachment 8514593 [details] [diff] [review]
iconheight.diff

Review of attachment 8514593 [details] [diff] [review]:
-----------------------------------------------------------------

So, this seems reasonable...but I think Florian hates this code. I'm OK w/ this change though...

        Attachment #8514593 -
        Flags: review?(clokep) → review+

    
    

    
  
It's ugly, there should be something like fixed-height in CSS to avoid the triplicates.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6

    
    

    
  
We should revisit the CSS in this file at some point...

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: