Closed
Bug 1091884
Opened 10 years ago
Closed 10 years ago
Status icon height too big in MUCs
Categories
(Instantbird Graveyard :: Conversation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: aleth, Assigned: aleth)
References
Details
(Keywords: regression)
Attachments
(2 files)
|
14.66 KB,
image/png
|
Details | |
|
737 bytes,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
Screenshot.png
See screenshot (19px not 16px). Probably crept in with the generic toolbar icon patch.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8514593 -
Flags: review?(clokep)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8514593 [details] [diff] [review]
iconheight.diff
Review of attachment 8514593 [details] [diff] [review]:
-----------------------------------------------------------------
So, this seems reasonable...but I think Florian hates this code. I'm OK w/ this change though...
Attachment #8514593 -
Flags: review?(clokep) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
It's ugly, there should be something like fixed-height in CSS to avoid the triplicates.
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
|
||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
|
|
Assignee | |
Comment 5•10 years ago
|
||
We should revisit the CSS in this file at some point...
You need to log in
before you can comment on or make changes to this bug.
Description
•