Closed Bug 1091917 Opened 5 years ago Closed 4 years ago
Enable leak logging for content processes on Windows
1. Fix bug 1073310. 2. Remove the |#if defined(XP_WIN)| block in |ShutdownXPCOM| that calls exit(0). 3. Remove the |if mozinfo.isWin: options.ignoreMissingLeaks.append["tab"]| block I'm going to add to mochitest_options.py in bug 1083897 so we require leak logs for content processes on Windows.
This is what step 2 and 3 from comment 0 is.
I think there are three remaining pieces of this: 1. bug 1193861 - Ensure child processes are recorded on Windows in the pidlog, so the test harness can tell if a process failed to create a log. 2. bug 1219369 - We're not actually recording leak logs on Windows 7 m-c due to sandboxing. 3. bug 1242119 - We're not getting leak logs on WinXP due to an early exit(0). Fixing this bug will then consist of removing this chunk from mochitest_options.py: if mozinfo.isWin: options.ignoreMissingLeaks.append("tab")
Currently, leakcheck ignores failures to produce a leak log on Windows for tab processes, because we don't ever generate a log for them. Once the blocking bugs are fixed, we will, so we should start enforcing that we actually doing leak checking. Try run with patches from the blocking bugs: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9261891222c5 I'll need to do a WinXP and Win8 try run to make sure it works on those platforms, but it looks like Win7 works.
Attachment #8715318 - Flags: review?(cmanchester)
Attachment #8514658 - Attachment is obsolete: true
Attachment #8715318 - Flags: review?(cmanchester) → review+
Still green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb639445f575 I'll land this when the tree reopens.
You need to log in before you can comment on or make changes to this bug.