1091917 - Enable leak logging for content processes on Windows

Status: RESOLVED FIXED

(Testing :: General, defect, P1)

Description

[Andrew McCreight [:mccr8]]

1. Fix bug 1073310.
2. Remove the |#if defined(XP_WIN)| block in |ShutdownXPCOM| that calls exit(0).
3. Remove the |if mozinfo.isWin: options.ignoreMissingLeaks.append["tab"]| block I'm going to add to mochitest_options.py in bug 1083897 so we require leak logs for content processes on Windows.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Run XPCOM shutdown on Windows in content processes and require leak logs.

This is what step 2 and 3 from comment 0 is.

Comment 2

[Andrew McCreight [:mccr8]]

This is probably the important remaining piece of bug 1051230.

Comment 3

[Andrew McCreight [:mccr8]]

I think there are three remaining pieces of this:
1. bug 1193861 - Ensure child processes are recorded on Windows in the pidlog, so the test harness can tell if a process failed to create a log.
2. bug 1219369 - We're not actually recording leak logs on Windows 7 m-c due to sandboxing.
3. bug 1242119 - We're not getting leak logs on WinXP due to an early exit(0).

Fixing this bug will then consist of removing this chunk from mochitest_options.py:

if mozinfo.isWin:
  options.ignoreMissingLeaks.append("tab")

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Stop ignoring failures to leak log on Windows.

Currently, leakcheck ignores failures to produce a leak log on Windows for tab processes, because we don't ever generate a log for them. Once the blocking bugs are fixed, we will, so we should start enforcing that we actually doing leak checking.

Try run with patches from the blocking bugs:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=9261891222c5

I'll need to do a WinXP and Win8 try run to make sure it works on those platforms, but it looks like Win7 works.

Comment 5

[Andrew McCreight [:mccr8]]

Still green:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb639445f575

I'll land this when the tree reopens.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9869446ba690

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9869446ba690