1091959 - [e10s] Don't send so many CPOWs in content policy shim

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: opt-shouldload

There are a couple of parameters to content policy shim that Adblock uses that we send using CPOWs but we don't have to. In particular:

- contentLocation is a URL
- so is requestOrigin

We can send the spec for these URLs rather than a CPOW for the nsIURL.

I also added requestPrincipal, which is a new parameter added to nsIContentPolicy. It can be sent without a CPOW as well since the message manager can send principals natively.

The fewer CPOWs we send, the faster Adblock gets.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

In a testcase I've been using, this reduces the number of CPOWs sent from 49492 to 30626.

Comment 2

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

Comment on attachment 8514710 [details] [diff] [review]
opt-shouldload

Review of attachment 8514710 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - and those CPOW stats are awesome. Keep it up!

::: toolkit/components/addoncompat/RemoteAddonsChild.jsm
@@ +142,5 @@
>        catMan.deleteCategoryEntry("content-policy", this._contractID, false);
>      }
>    },
>  
> +  shouldLoad: function(contentType, contentLocation, requestOrigin, node, mimeTypeGuess, extra, requestPrincipal) {

Nit - let's break this up over a pair of lines, if we can.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/53a8066df9a9

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/53a8066df9a9