1092001 - Fix warnings in dom/tv and mark as FAIL_ON_WARNINGS

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-tv-warnings.patch

This patch fixes the following clang warnings recently introduced in bug 998872 and marks the dom/tv directory as FAIL_ON_WARNINGS:

> dom/tv/FakeTVService.cpp:229:397: error: deleting object of polymorphic class type 'mozilla::dom::EITBroadcastedCallback' which has non-virtual destructor might cause undefined behaviour [-Werror=delete-non-virtual-dtor]
> dom/tv/FakeTVService.cpp:258:393: error: deleting object of polymorphic class type 'mozilla::dom::ScanCompleteCallback' which has non-virtual destructor might cause undefined behaviour [-Werror=delete-non-virtual-dtor]
> dom/tv/TVListeners.cpp:15:1 [-Wdelete-non-virtual-dtor] delete called on 'mozilla::dom::TVSourceListener' that has virtual functions but non-virtual destructor
> dom/tv/TVProgram.h:74:8 [-Wunused-private-field] private field 'mIsInterrupting' is not used

Here's a green Try build:
https://tbpl.mozilla.org/?tree=Try&rev=c8e3d4b360ec

Comment 1

[(no longer active)]

Comment on attachment 8514789 [details] [diff] [review]
fix-tv-warnings.patch

Review of attachment 8514789 [details] [diff] [review]:
-----------------------------------------------------------------

r=me sans the already fixed stuff.

::: dom/tv/TVListeners.h
@@ +14,5 @@
>  
>  namespace mozilla {
>  namespace dom {
>  
> +class TVSourceListener MOZ_FINAL : public nsITVSourceListener

I just fixed this on inbound. :-)

::: dom/tv/TVProgram.h
@@ -70,5 @@
>    uint64_t mStartTime;
>    uint64_t mDuration;
>    nsString mDescription;
>    nsString mRating;
> -  bool mIsInterrupting;

This too.

Comment 2

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a4eb24614d1

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4a4eb24614d1