mozMobileConnection.data.cell is reset to `null` unexpectedly in MobileConnectionService

RESOLVED FIXED in 2.1 S8 (7Nov)

Status

Firefox OS
RIL
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: edgar, Assigned: edgar)

Tracking

({regression})

unspecified
2.1 S8 (7Nov)
ARM
Linux
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Found this by running single marionette test, test_mobile_data_location.js.
(Assignee)

Updated

3 years ago
Summary: mobileConnection.cell is reset to `null` unexpectedly in MobileConnectionService → mozMobileConnection.data.cell is reset to `null` unexpectedly in MobileConnectionService
(Assignee)

Comment 1

3 years ago
It is a regression of bug 1063304.
Blocks: 1063304
(Assignee)

Updated

3 years ago
Assignee: nobody → echen
(Assignee)

Comment 2

3 years ago
The design of updating function (e.g. _updateConnectionInfo() [1]) is to perform updating *only if* new data is passed. Thus, if no new data is passed into updating function, it should just keep the original data unchanged.

[1] http://dxr.mozilla.org/mozilla-central/source/dom/mobileconnection/gonk/MobileConnectionService.js#481-521
(Assignee)

Comment 3

3 years ago
Created attachment 8514823 [details] [diff] [review]
Patch, v1
(Assignee)

Comment 4

3 years ago
Comment on attachment 8514823 [details] [diff] [review]
Patch, v1

Please see comment #2, thank you.
Attachment #8514823 - Flags: review?(htsai)
(Assignee)

Updated

3 years ago
Keywords: regression
(Assignee)

Comment 5

3 years ago
Created attachment 8515577 [details] [diff] [review]
Part 2: Enable ril debug when running mobileConnection tests, v1
(Assignee)

Comment 6

3 years ago
Comment on attachment 8515577 [details] [diff] [review]
Part 2: Enable ril debug when running mobileConnection tests, v1

Review of attachment 8515577 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Hsinyi, may I have your review? Thank you.
Attachment #8515577 - Flags: review?(htsai)
Comment on attachment 8514823 [details] [diff] [review]
Patch, v1

Review of attachment 8514823 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you! Please add a comment on the design.
Attachment #8514823 - Flags: review?(htsai) → review+

Updated

3 years ago
Attachment #8515577 - Flags: review?(htsai) → review+
(Assignee)

Comment 8

3 years ago
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #7)
> Comment on attachment 8514823 [details] [diff] [review]
> Patch, v1
> 
> Review of attachment 8514823 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thank you! Please add a comment on the design.

Will do, thank you.
(Assignee)

Comment 9

3 years ago
Created attachment 8516458 [details] [diff] [review]
Part 1: mozMobileConnection.data.cell is reset to `null` unexpectedly in MobileConnectionService, v2, r=hsinyi

Add comments about the design of updating function.
Attachment #8514823 - Attachment is obsolete: true
Attachment #8516458 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/64db7d36f278
https://hg.mozilla.org/mozilla-central/rev/566f2111af95
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in before you can comment on or make changes to this bug.