Fix -Wunused-const-variable warning in security/pkix/test/gtest

RESOLVED FIXED in Firefox 36

Status

()

Core
Security: PSM
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Blocks: 1 bug)

Trunk
mozilla36
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox35 unaffected, firefox36 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8514804 [details] [diff] [review]
fix-pkix-warning.patch

ipv4_addr_bytes_FFFFFFFF was added to pkixnames_tests.cpp in bug 1089393, but it is never referenced. This directory is marked FAIL_ON_WARNINGS, so I'm not sure why neither the build machines nor other developers hit this warning-as-error:

> security/pkix/test/gtest/pkixnames_tests.cpp:1030:22: error: unused variable 'ipv4_addr_bytes_FFFFFFFF' [-Werror,-Wunused-const-variable]

Brian, did you intend to add test cases that would use ipv4_addr_bytes_FFFFFFFF?
Attachment #8514804 - Flags: review?(brian)
(In reply to Chris Peterson (needinfo? :cpeterson) from comment #0)
> This directory is marked FAIL_ON_WARNINGS, so
> I'm not sure why neither the build machines nor other developers hit this
> warning-as-error:

(I just hit it myself, FWIW, and almost filed a dupe of this bug. I think -Wunused-const-variable is a relatively new clang-only warning, and the build machines don't have new-enough clang to report it.)
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Comment on attachment 8514804 [details] [diff] [review]
fix-pkix-warning.patch

Review of attachment 8514804 [details] [diff] [review]:
-----------------------------------------------------------------

This was the result of a bad merge. This unused value will be used in an upcoming patch series.
Attachment #8514804 - Flags: review?(brian) → review+
(Assignee)

Comment 3

4 years ago
Thanks, Brian.

https://hg.mozilla.org/integration/mozilla-inbound/rev/218b552c815b
status-firefox36: affected → fixed
https://hg.mozilla.org/mozilla-central/rev/218b552c815b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36

Updated

3 years ago
See Also: → bug 1108637
You need to log in before you can comment on or make changes to this bug.