1092028 - Fix -Wunused-const-variable warning in security/pkix/test/gtest

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-pkix-warning.patch

ipv4_addr_bytes_FFFFFFFF was added to pkixnames_tests.cpp in bug 1089393, but it is never referenced. This directory is marked FAIL_ON_WARNINGS, so I'm not sure why neither the build machines nor other developers hit this warning-as-error:

> security/pkix/test/gtest/pkixnames_tests.cpp:1030:22: error: unused variable 'ipv4_addr_bytes_FFFFFFFF' [-Werror,-Wunused-const-variable]

Brian, did you intend to add test cases that would use ipv4_addr_bytes_FFFFFFFF?

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Chris Peterson (needinfo? :cpeterson) from comment #0)
> This directory is marked FAIL_ON_WARNINGS, so
> I'm not sure why neither the build machines nor other developers hit this
> warning-as-error:

(I just hit it myself, FWIW, and almost filed a dupe of this bug. I think -Wunused-const-variable is a relatively new clang-only warning, and the build machines don't have new-enough clang to report it.)

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8514804 [details] [diff] [review]
fix-pkix-warning.patch

Review of attachment 8514804 [details] [diff] [review]:
-----------------------------------------------------------------

This was the result of a bad merge. This unused value will be used in an upcoming patch series.

Comment 3

[Chris Peterson [:cpeterson]]

Thanks, Brian.

https://hg.mozilla.org/integration/mozilla-inbound/rev/218b552c815b

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/218b552c815b