1092074 - Make log shake robust to log parsing failures

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Developer Tools, defect)

Description

[:gerard-majax]

In bug 1079322 we have an issue where some parsing fails. This makes the whole feature being completely broken: we should avoid this. Instead, we should be as much resilient as possible, and in cases like this one we should:
 - dump an error in console
 - continue with the next log

Comment 1

[:gerard-majax]

Attachment: Make LogShake feature resilient to read/parse errors r=gwagner

In the event of broken/unexpected things, we would like to have even a
partial log set dump. This happens for parsing properties values on
Kitkat builds: the current code does all the parsing itself, but the
format of storage of properties evolved with Kitkat base system, and
this makes LogParser to fail, as documented in bug 1079322. Even if we
miss some values, it can still be useful to have the other remaining
ones.

Comment 2

[:gerard-majax]

Comment on attachment 8514948 [details] [diff] [review]
Make LogShake feature resilient to read/parse errors r=gwagner

Gregor, I'm r? you since you reviewed previous patches on LogShake. But feel free to redirect if needed :)

Move of the changes are just to move code inside the LogShake object, so that we can properly test in xpcshell unit test.

Comment 3

[:gerard-majax]

Attachment: Running xpcshell test without the try/catch fixes

Comment 4

[:gerard-majax]

Attachment: Running xpcshell test with the try/catch fixes

Comment 5

[:gerard-majax]

With attachment 8514952 [details] and attachment 8514953 [details], we see how the new test fails without the fix.
A pending try has been triggered on https://tbpl.mozilla.org/?tree=Try&rev=a7db0463597c
Local testing on Kitkat shows this works as expected.

Comment 6

[:gerard-majax]

With try green: https://tbpl.mozilla.org/?tree=Try&rev=a7db0463597c

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/dad2b67b9f77

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dad2b67b9f77