Fix a few build warnings on debug x86 build and opt builds

RESOLVED FIXED in mozilla36

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bbouvier, Assigned: bbouvier)

Tracking

(Blocks: 1 bug)

Trunk
mozilla36
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8514956 [details] [diff] [review]
Fix a signed/unsigned comparison in JitcodeMap

Apparently |end - curEntry| is considered as signed, so let's just make it
explicitly an unsigned pointer value (end is guaranteed to be > than curEntry
in ExpectedRunLength).

And a drive by trailing whitespace cleaning as well.
Attachment #8514956 - Flags: review?(kvijayan)
(Assignee)

Comment 2

4 years ago
Created attachment 8514957 [details] [diff] [review]
Unused partialNunbox_

Fallout of bug 1066659, which removed all uses but not the field itself.
Attachment #8514957 - Flags: review?(bhackett1024)
(Assignee)

Comment 3

4 years ago
Created attachment 8514958 [details] [diff] [review]
Make a few functions / variables debugonly

This moves a few functions / variables into #ifdef DEBUG blocks, moves some variables into their MOZ_ASSERT only-uses, makes some variables DebugOnly. This reduces a lot the number of warnings in all builds (gcc x64 opt & debug, gcc x32 opt & debug, and sames for clang).

Jason, asking review to you as it touches a lot of parts of the JS engine, feel free to bounce to anybody else.
Attachment #8514958 - Flags: review?(jorendorff)
(Assignee)

Comment 4

4 years ago
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c6873b761b99 (shared x86 codegen patch has been folded into the last patch in the meanwhile)
Attachment #8514957 - Flags: review?(bhackett1024) → review+
Comment on attachment 8514958 [details] [diff] [review]
Make a few functions / variables debugonly

Review of attachment 8514958 [details] [diff] [review]:
-----------------------------------------------------------------

> Bug 1092110: Make a few functions and members debug only;
> * * *
> Bug 1092110: Move some debug only declarations into assertions; r=sunfish

Don't forget to fix the commit message
Blocks: 187528
Comment on attachment 8514958 [details] [diff] [review]
Make a few functions / variables debugonly

Review of attachment 8514958 [details] [diff] [review]:
-----------------------------------------------------------------

If it builds it seems ok.
Attachment #8514958 - Flags: review?(jorendorff) → review+
Comment on attachment 8514956 [details] [diff] [review]
Fix a signed/unsigned comparison in JitcodeMap

Review of attachment 8514956 [details] [diff] [review]:
-----------------------------------------------------------------

Looks functionally correct.
Attachment #8514956 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/mozilla-central/rev/81998c889766
https://hg.mozilla.org/mozilla-central/rev/9c0efc3d1207
https://hg.mozilla.org/mozilla-central/rev/6e3bfcef5b4b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.