1092110 - Fix a few build warnings on debug x86 build and opt builds

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Fix a signed/unsigned comparison in JitcodeMap

Apparently |end - curEntry| is considered as signed, so let's just make it
explicitly an unsigned pointer value (end is guaranteed to be > than curEntry
in ExpectedRunLength).

And a drive by trailing whitespace cleaning as well.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Unused partialNunbox_

Fallout of bug 1066659, which removed all uses but not the field itself.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Make a few functions / variables debugonly

This moves a few functions / variables into #ifdef DEBUG blocks, moves some variables into their MOZ_ASSERT only-uses, makes some variables DebugOnly. This reduces a lot the number of warnings in all builds (gcc x64 opt & debug, gcc x32 opt & debug, and sames for clang).

Jason, asking review to you as it touches a lot of parts of the JS engine, feel free to bounce to anybody else.

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c6873b761b99 (shared x86 codegen patch has been folded into the last patch in the meanwhile)

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8514958 [details] [diff] [review]
Make a few functions / variables debugonly

Review of attachment 8514958 [details] [diff] [review]:
-----------------------------------------------------------------

> Bug 1092110: Make a few functions and members debug only;
> * * *
> Bug 1092110: Move some debug only declarations into assertions; r=sunfish

Don't forget to fix the commit message

Comment 6

[Douglas Crosher [:dougc]]

Comment on attachment 8514958 [details] [diff] [review]
Make a few functions / variables debugonly

Review of attachment 8514958 [details] [diff] [review]:
-----------------------------------------------------------------

If it builds it seems ok.

Comment 7

[Douglas Crosher [:dougc]]

Comment on attachment 8514956 [details] [diff] [review]
Fix a signed/unsigned comparison in JitcodeMap

Review of attachment 8514956 [details] [diff] [review]:
-----------------------------------------------------------------

Looks functionally correct.

Comment 8

[Benjamin Bouvier [:bbouvier] (inactive)]

Thanks douglas for stealing the reviews!

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/81998c889766
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/9c0efc3d1207
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/6e3bfcef5b4b

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/81998c889766
https://hg.mozilla.org/mozilla-central/rev/9c0efc3d1207
https://hg.mozilla.org/mozilla-central/rev/6e3bfcef5b4b