1092163 - after restart, restored e10s windows are non-e10s when tracking protection is enabled

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Both I and Jimm have seen this today

Comment 1

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0f8732b3b6e7

Comment 2

[:Gavin Sharp [email: [e-mail]]]

This is an intended temporary state for the 10th anniversary announcements.

Can't test e10s and tracking protection at the same time.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

I'm going to use this bug for backing this out now that tracking protection works with e10s.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch

This has r=blassey in person.

Comment 5

[[:mmc] Monica Chew (no longer reading bugmail)]

I think this breaks the Polaris pref test which expects dnt not to be turned off if Polaris is disabled.

Comment 6

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8520826 [details] [diff] [review]
patch

Review of attachment 8520826 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/nsBrowserGlue.js
@@ +422,1 @@
>          }

if (enabled) {
  // Set all 3 prefs
} else {
  // Unset 2 prefs
  Services.clearUserPref("privacy.trackingprotection.enabled");
  Services.clearUserPref("privacy.trackingprotection.ui.enabled");
}

see browser/components/test/browser_polaris_prefs.js

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5cf41ab7e2f9 with comment 6 addressed.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5cf41ab7e2f9

Comment 9

[Catalin Varga [QA][:VarCat]]

Verified as fixed using the following environment:

FF 38
Build Id:20150219070749
OS: Win 7 x64, Mac Os X 10.10, Ubuntu 12.04 x86