1092254 - Use Solo.waitForCondition under the hood in BaseTest.waitForTest

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

waitForCondition will likely be more robust because we don't have to maintain it.

e.g. waitForTest might be causing background thread starvation issues in bug 1090618.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Use Solo.waitForCondition under the hood in BaseTest.waitForTest

Comment 2

[Geoff Brown [:gbrown]]

It should be possible to convert clients of waitForTest to use waitForCondition instead, and then we could remove waitForTest entirely.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Geoff Brown [:gbrown] from comment #2)
> It should be possible to convert clients of waitForTest to use
> waitForCondition instead, and then we could remove waitForTest entirely.

True, but it will take a while and I have other things to do - looks like a good mentored bug (someone had my idea! bug 982797).

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://tbpl.mozilla.org/?tree=Try&rev=7afc84b44dcc

Comment 5

[Chenxia Liu [:liuche]]

Comment on attachment 8515139 [details] [diff] [review]
Use Solo.waitForCondition under the hood in BaseTest.waitForTest

Review of attachment 8515139 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/tests/BaseTest.java
@@ +333,5 @@
> +     * @deprecated use {@link #waitForCondition(Condition, int)} instead
> +     */
> +    @Deprecated
> +    protected final boolean waitForTest(final BooleanTest t, final int timeout) {
> +        final boolean wasSatisfied = mSolo.waitForCondition(new Condition() {

Nit: I would prefer isSatisfied instead of wasSatisfied per general naming convention, but up to you.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Use Solo.waitForCondition under the hood in BaseTest.waitForTest

was -> is

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/3ac2eb20194b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3ac2eb20194b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/180de799976d
https://hg.mozilla.org/releases/mozilla-beta/rev/cdd31f8931ae