1092258 - test_bugzilla.py shouldn't have a hardcoded count of the bugs in sample_data/bug_list.json

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder: Data Ingestion, defect, P5)

Description

[Ed Morley [:emorley]]

...otherwise it has to be updated every time a new example bug is added to bug_list.json, which is non-obvious, even the tests that use it are in several directories, so may not get run locally.

https://github.com/mozilla/treeherder-service/blob/master/tests/etl/test_bugzilla.py#L41

Comment 1

[anejaalisha]

If it won't be hardcoded, will there have to be a count variable which increments everytime an example is added?

Comment 2

[Ed Morley [:emorley]]

Hmm looking into this more I don't think it's worth trying to fix this. The way to get the count would be to check how many bugs are present in the json file loaded here:
https://github.com/mozilla/treeherder/blob/74b9b003b7b3bb85449a0dee31abaa0159670a4f/tests/conftest.py#L528-L536

If the current mocking were say using responses, this would be simpler with less duplication, but as-is it's probably not worth it.