1092270 - Make jpm test --debug work, and only load main after the debugger has loaded

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

Moving https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/addon/runner.js#L160-L162 just before https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/addon/runner.js#L145 making sure to call `main(options.loader, options.main);` only after the debugger is setup should resolve this issue.

Basically we need to load the debugger before loading the main script for an add-on, in order to catch `debugger;` statements

Comment 1

[Florent Fayolle]

I fear it won't be so easy. The Browser Toolbox looks to be initiated asynchronously.
https://hg.mozilla.org/mozilla-central/file/ad6298e44579/browser/devtools/framework/ToolboxProcess.jsm#l203

What would be great is a callback from the toolbox (a RDP message or so) telling that it is wholly loaded (with the Debugger, etc.).

Florent

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Note: Need to make a related devtools bug here.

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

Filed bug 1112293

Comment 4

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562