Closed Bug 1092317 Opened 6 years ago Closed 6 years ago

Talos logparsing problems

Categories

(Tree Management :: Treeherder, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wlach, Assigned: wlach)

Details

Attachments

(1 file)

When we were trying to figure out what was going on with the performance artifact ingestion, we noticed some minor issues with the talos logparser:

1. It doesn't fail noisily if it encounters a badly formed TALOSDATA or TalusResult line.
2. We want a "TalosResult" artifact, but we're sometimes prematurely truncating that line (and weren't noticing that because of (1)).
3. We should have unit tests for logparser failure cases, as well as success ones
Attached file PR with fixes
Assignee: nobody → wlachance
Attachment #8515222 - Flags: review?(mdoglio)
Attachment #8515222 - Flags: review?(mdoglio) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.