Closed Bug 1092339 Opened 7 years ago Closed 7 years ago

Logviewer: Log chunks fail to load on loadMore() due to Angular 1.3 update

Categories

(Tree Management :: Treeherder, defect, P1)

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jfrench, Assigned: camd)

References

()

Details

Attachments

(1 file)

49 bytes, text/x-github-pull-request
mdoglio
: review+
Details | Review
Log chunks fail to load in the logviewer on scroll. To reproduce:

o click on any job
o open the logviewer
o click on any failure step to load the log
o page down/up or scroll, to trigger a new log chunk load

Expected:
A new log chunk loads.

Observed:
Nothing occurs and this error is sent to the console:

"Error: [$parse:isecdom] Referencing DOM nodes in Angular expressions is disallowed! Expression: loadMore(bounds, element)".

Cameron is having a look. The relevant part is here in the Angular 1.3 docs
https://docs.angularjs.org/error/$parse/isecdom
Attached file treeherder-ui-PR#257
Camd has opened the above PR for review. I'll guess, and set Mauro for it if that is ok :)
Attachment #8515426 - Flags: review?(mdoglio)
Blocks: 1084608
Attachment #8515426 - Flags: review?(mdoglio) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Verified fixed and working correctly on stage.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.