Logviewer: Log chunks fail to load on loadMore() due to Angular 1.3 update

VERIFIED FIXED

Status

P1
major
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: jfrench, Assigned: camd)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Log chunks fail to load in the logviewer on scroll. To reproduce:

o click on any job
o open the logviewer
o click on any failure step to load the log
o page down/up or scroll, to trigger a new log chunk load

Expected:
A new log chunk loads.

Observed:
Nothing occurs and this error is sent to the console:

"Error: [$parse:isecdom] Referencing DOM nodes in Angular expressions is disallowed! Expression: loadMore(bounds, element)".

Cameron is having a look. The relevant part is here in the Angular 1.3 docs
https://docs.angularjs.org/error/$parse/isecdom
(Reporter)

Comment 1

4 years ago
Created attachment 8515426 [details] [review]
treeherder-ui-PR#257

Camd has opened the above PR for review. I'll guess, and set Mauro for it if that is ok :)
Attachment #8515426 - Flags: review?(mdoglio)

Updated

4 years ago
Blocks: 1084608
Attachment #8515426 - Flags: review?(mdoglio) → review+
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

4 years ago
Verified fixed and working correctly on stage.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.