1092339 - Logviewer: Log chunks fail to load on loadMore() due to Angular 1.3 update

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Jonathan French (:jfrench)]

Log chunks fail to load in the logviewer on scroll. To reproduce:

o click on any job
o open the logviewer
o click on any failure step to load the log
o page down/up or scroll, to trigger a new log chunk load

Expected:
A new log chunk loads.

Observed:
Nothing occurs and this error is sent to the console:

"Error: [$parse:isecdom] Referencing DOM nodes in Angular expressions is disallowed! Expression: loadMore(bounds, element)".

Cameron is having a look. The relevant part is here in the Angular 1.3 docs
https://docs.angularjs.org/error/$parse/isecdom

Comment 1

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#257

Camd has opened the above PR for review. I'll guess, and set Mauro for it if that is ok :)

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/3630e542ff323679e4506eb50b53cc724b7db779
bug 1092339 - fixed logviewer infinite scrolling

Comment 3

[Jonathan French (:jfrench)]

Verified fixed and working correctly on stage.

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2d426e011404fb7d24fef71bcdd49ef813f1dccf
bug 1092339 - fixed logviewer infinite scrolling