1092384 - [Settings] JS warning: SettingsRequestManager.jsm, line 891: ReferenceError: reference to undefined property msg.windowID

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

On current b-i with debug gecko build during startup

Comment 1

[:gerard-majax]

That's probably because Settings:CreateLock from SettingsService has no windowID.

Comment 2

[:gerard-majax]

When fixing bug 1082001, I added a windowID propety to the object we pass with the "Settings:CreateLock" message, but forgot to do the change for SettingsService.js.

Comment 3

[:gerard-majax]

Attachment: Use undefined windowID for service locks r=bent

Service locks for settings are locks created from chrome code and not
attached to any window. Since the windowID is used in other cases for
the Settings:CreateLock message, we should at least pass an undefined
value to avoid unneccessary JS warning.

Comment 4

[:gerard-majax]

try: https://tbpl.mozilla.org/?tree=Try&rev=ab5cf5d3bea0

Comment 5

[:gerard-majax]

Comment on attachment 8516708 [details] [diff] [review]
Use undefined windowID for service locks r=bent

Ben, would you mind reviewing this?

Comment 6

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/b2g-inbound/rev/b93e840f3ebb

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b93e840f3ebb