1092394 - [Contacts] Accessing the contact details from the call log "Call information", the User lands briefly in "Import Contacts" before transitioning to the contact details screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Fred Muyumba [:FredM]]

Attachment: logcat_20141031_1509.txt

Description:
Accessing the contact details from the call log's "Call information" the User lands briefly in either the "Import Contacts" or "Contacts" screen before transitioning to the "Contact details" screen
   
Repro Steps:
1) Update a Flame device to BuildID: 20141031001201
2) Import contacts > Make some calls
3) Open the Call log > Long tap on contact > Tap on "Call information"
4) Tap on "Contact details"> Observe what happens
5) Tap on Back button > Observe what happens
  
  
Actual:
The User lands briefly in either "Import Contacts" or "Contacts" before transitioning to the "Contact details" screen
  
Expected: 
The User transitions to the "Contact details" screen
  
Environmental Variables:
Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141031001201
Gaia: f89c7b12c36572262c9ea76058694a139b1a8634
Gecko: 50d48f8a04c7
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
  
Repro frequency: 100%
See attached: video clip & logcat: http://youtu.be/0alU5EBZZKg

Comment 1

[Fred Muyumba [:FredM]]

This issue is reproducible on Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)

Result: The User lands briefly in either "Import Contacts" or "Contacts" before transitioning to the "Contact details" screen

I did not test the Flame 2.0 (319mb)(Kitkat Base)(Full Flash) because the feature does not exist

Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141031061804
Gaia: a07994714f0552f89801d6097982308d8b0a1ee1
Gecko: 6bd2071b373f
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1  
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 2

[Joshua Mitchell (Inactive)]

NI to contacts owner for blocking call

Comment 3

[Johan Lorenzo [:jlorenzo]]

At first, I would say the issue is not major enough to be considered as a blocker. As this is a new feature, I prefer ask UX if they would block on that.

Comment 4

[Carrie Wang [New account: [e-mail]]]

We used to have this transition issues everywhere in Contacts (e.g add to an existing contact from contact details) and I know that devs have been working on it. This is not a new feature, but I don't think it's that serious to be a blocker either. We should assign someone to fix and it will look fine then. Thanks!

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Let's target it for next sprint, I do agree with Carrie and Johan, let's fix it but we would love to solve the problem of having to navigate between views instead of landing on the view directly (another huge feature)

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26068

Comment 7

[Jose Manuel Cantera]

Comment on attachment 8521431 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26068

works perfectly. please check the nits on GH and land once TBPL is green

thanks Fernando

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Thanks!

https://github.com/mozilla-b2g/gaia/commit/dadf2e437548bb86fd6075eb93d63f687b016988