109240 - second line of comment in email is too long when attachment created

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect, P2)

Description

[Myk Melez [:myk] [@mykmelez]]

When you create an attachment, a comment is submitted to the bug about it. 
Email then gets sent out about the attachment creation, and that email contains
the comment.  The second line of the comment is too long and looks really horrible.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: test case: email with line that is too long

Comment 2

[GavinS]

The original bug which added the URL to the attachment was bug#66651.

I think that was OK, in that the short description of the attachment started on
the next line.

Now, on line 487 of the new attachment.cgi, I think you need a new line after
the '(id=$attachid)' bit, as this is where processmail turns the text into an
URL

Comment 3

[GavinS]

*** Bug 109290 has been marked as a duplicate of this bug. ***

Comment 4

[[e-mail]]

My search for this bug failed because it was filed under the wrong component.

My suggestion from bug 109290 is as follows:

processmail, line 987ish

$newcomments =~
    s/(Created an attachment \(id=(\d+)\))/${showattachurlbase}$2\n$1/g;

Comment 5

[Jacob Steenhagen]

Attachment: Put a "\n" in the comment instead of ": "

Maybe I'm just being nostalgic, but I actually like the attachment's
description being on the line below the "Created an Attachment" message rather
than on the same line seperated by a colon.

Comment 6

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 57221 [details] [diff] [review]
Put a "\n" in the comment instead of ": "

Works, r=myk, no second review needed.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Attachment: testing application of patch on b.m.o. to fix regression

Since this bug is a regression I have applied the fix to b.m.o. and am now
testing it.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Checked in.  Resolving fixed.

Comment 10

[Dave Miller [:justdave]]

fixing incorrect milestones on fixed bugs.