Closed Bug 1092421 Opened 9 years ago Closed 9 years ago

Remove locale migration code

Categories

(Firefox for Android Graveyard :: Locale switching and selection, defect)

Product:
Firefox for Android Graveyard
Component:
Locale switching and selection
Version:
35 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox35 fixed, firefox36 fixed, fennec35+)

Status:
RESOLVED FIXED
Milestone:
Firefox 36
Tracking Flags:
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
fennec 35+ ---

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file)

Remove locale migration code from browser.js. v1
2.47 KB, patch
mfinkle
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Following up from Bug 1091803, which introduced a chunk of code in BrowserApp.startup to fix up dodgy prefs.

The bug it fixes is in 35, which is currently in Aurora, and won't be in Beta.

We can remove this hack once it's been in a couple of 35 Auroras and 36 Nightlies.

We can also remove the code before 35 goes to Beta.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
This should land any time between now and merge day.
Attachment #8521603 - Flags: review?(mark.finkle)
Attachment #8521603 - Flags: review?(mark.finkle) → review+
Comment on attachment 8521603 [details] [diff] [review]
Remove locale migration code from browser.js. v1

Approval Request Comment
[Feature/regressing bug #]:
  Removing a migration fix that was temporarily introduced in Bug 1091803.

[User impact if declined]:
  Continued running of migration/fixup code that isn't necessary in beta or release.

[Describe test coverage new/current, TBPL]:
  None.

[Risks and why]: 
  We needed to migrate broken Nightly and Aurora clients. This code did that. It's now been around for long enough that we can remove it; the broken code was only present in 36 Nightly and 35 Aurora.

[String/UUID change made/needed]:
  None.
Attachment #8521603 - Flags: approval-mozilla-aurora?
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox36: affected → fixed
Keywords: leave-open
Resolution: --- → FIXED
Attachment #8521603 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.