reviewboard extension not loading on Windows due to json import

RESOLVED FIXED

Status

MozReview
General
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: gps, Unassigned)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

38 bytes, text/x-review-board-request
smacleod
: review+
mconley
: review+
Details | Review
(Reporter)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1077326 +++

Splitting this bug from original report to track reviewboard extension work, as that is all I fixed while on the plane earlier.
(Reporter)

Comment 1

3 years ago
Created attachment 8515422 [details]
MozReview Request: bz://1092476/gps
Attachment #8515422 - Flags: review?(smacleod)
(Reporter)

Comment 2

3 years ago
/r/145 - reviewboard: don't always import json (bug 1092476)

Pull down this commit:

hg pull review -r cb1fefc4e04bfff377a9976f4967ae2e736be872
https://reviewboard.mozilla.org/r/143/#review121

::: testing/find-bad-imports.py
(Diff revision 1)
> +Once the test harness runs on Windows, we can probably remove this.

Probably a good idea to file a bug to remove this then.

::: hgext/reviewboard/hgrb/proto.py
(Diff revision 1)
> +    import json

I guess this just kicks the can down the road until the user on Windows tries to run this command? Or until the test harness is made to run on Windows, I guess.
(Reporter)

Comment 4

3 years ago
https://reviewboard.mozilla.org/r/143/#review137

> I guess this just kicks the can down the road until the user on Windows tries to run this command? Or until the test harness is made to run on Windows, I guess.

No, this code only runs on the server. It should never be relevant for clients.
(Reporter)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Comment on attachment 8515422 [details]
MozReview Request: bz://1092476/gps

LGTM as well.
Attachment #8515422 - Flags: review?(smacleod) → review+
(Reporter)

Comment 7

3 years ago
Comment on attachment 8515422 [details]
MozReview Request: bz://1092476/gps
Attachment #8515422 - Attachment is obsolete: true
Attachment #8618539 - Flags: review+
(Reporter)

Comment 8

3 years ago
Created attachment 8618539 [details]
MozReview Request: reviewboard: don't always import json (bug 1092476)
(Assignee)

Updated

2 years ago
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.