1092476 - reviewboard extension not loading on Windows due to json import

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Gregory Szorc [:gps]]

+++ This bug was initially created as a clone of Bug #1077326 +++

Splitting this bug from original report to track reviewboard extension work, as that is all I fixed while on the plane earlier.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bz://1092476/gps

Comment 2

[Gregory Szorc [:gps]]

/r/145 - reviewboard: don't always import json (bug 1092476)

Pull down this commit:

hg pull review -r cb1fefc4e04bfff377a9976f4967ae2e736be872

Comment 3

[Mike Conley (:mconley) (:⚙️)]

https://reviewboard.mozilla.org/r/143/#review121

::: testing/find-bad-imports.py
(Diff revision 1)
> +Once the test harness runs on Windows, we can probably remove this.

Probably a good idea to file a bug to remove this then.

::: hgext/reviewboard/hgrb/proto.py
(Diff revision 1)
> +    import json

I guess this just kicks the can down the road until the user on Windows tries to run this command? Or until the test harness is made to run on Windows, I guess.

Comment 4

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/143/#review137

> I guess this just kicks the can down the road until the user on Windows tries to run this command? Or until the test harness is made to run on Windows, I guess.

No, this code only runs on the server. It should never be relevant for clients.

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/54cd3ca90d5d

Comment 6

[Steven MacLeod [:smacleod]]

Comment on attachment 8515422 [details]
MozReview Request: bz://1092476/gps

LGTM as well.

Comment 8

[Gregory Szorc [:gps]]

Attachment: MozReview Request: reviewboard: don't always import json (bug 1092476)